[Android] Add chrome_java target for building Java code in the chromium layer.

[Android] Add chrome_java target for building Java code in the chromium layer.

Also includes a refactoring of the Ant xml scripts to use a common template (contributed by shashishekhar@chromium.org). As part of this, I also continued Torne's effort of removing our reliance on environment variables. Unfortunately this currently means that you have to specify 5 gyp flags:
    ANDROID_SDK, ANDROID_SDK_ROOT, ANDROID_SDK_TOOLS, ANDROID_SDK_VERSION, ANDROID_TOOLCHAIN.
    
This'll get better as we make further use of the checked in sdk both upstream and downstream. The problem stems from the android tree and released sdk having different configurations.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150172

[Yaron, 2012-07-25 15:59:29]

http://codereview.chromium.org/10830012/diff/1/chrome/chrome_tests.gypi
File chrome/chrome_tests.gypi (right):

http://codereview.chromium.org/10830012/diff/1/chrome/chrome_tests.gypi#newco...
chrome/chrome_tests.gypi:4695: '<(PRODUCT_DIR)/lib.java/chromium_base.jar',
I didn't actually include the jar here. I was more interested in the build dep
but perhaps we need to include all the jars too although currently there's no
deps on the actual java files

[nilesh, 2012-07-25 16:57:12]

Sorry for nitpicking :) But I see this as an opportunity to get our xml build
files to a common style.

[nilesh, 2012-07-25 16:57:21]

http://codereview.chromium.org/10830012/diff/1/build/android/ant/chromium-jar...
File build/android/ant/chromium-jars.xml (right):

http://codereview.chromium.org/10830012/diff/1/build/android/ant/chromium-jar...
build/android/ant/chromium-jars.xml:35: description="Compiles source." >
looks like description will fit on the line above.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/chromium-jar...
build/android/ant/chromium-jars.xml:52: description="Generate
chromium_${PACKAGE_NAME}.jar." >
I think 4 space indent for continuation will make it more distinguishable. Here
and elsewhere.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/chromium-jar...
build/android/ant/chromium-jars.xml:59: description="clean up" >
no line break needed.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml
File build/android/ant/common.xml (right):

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml#n...
build/android/ant/common.xml:8: <!--
<!-- Common build properties for Chrome for android. -->

For one line comments?

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml#n...
build/android/ant/common.xml:12: <!-- Macro for checking that a property is
correctly set.
We should settle on one format for multi-line comments.
What about the format at the top.
<!--
  ....
-->

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml#n...
build/android/ant/common.xml:32: -->
Match this with <!--

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml#n...
build/android/ant/common.xml:37: </condition>
fix indent.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml#n...
build/android/ant/common.xml:45: -->
This has a different indentation than the comments at the top.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml#n...
build/android/ant/common.xml:93: 
remove trailing new lines.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/sdk-targets.xml
File build/android/ant/sdk-targets.xml (right):

http://codereview.chromium.org/10830012/diff/1/build/android/ant/sdk-targets....
build/android/ant/sdk-targets.xml:24: <isreference
refid="javac.custom.sourcepath" />
This file has 4-space indent. Looks very different from other files.

http://codereview.chromium.org/10830012/diff/1/chrome/android/java/chrome.xml
File chrome/android/java/chrome.xml (right):

http://codereview.chromium.org/10830012/diff/1/chrome/android/java/chrome.xml...
chrome/android/java/chrome.xml:3: Use of this source code is governed by a
BSD-style license that can be
Comment format.

[shashi, 2012-07-25 17:17:11]

Ahh.. I realize now so many white space errors I made during the refactoring.

[Yaron, 2012-07-25 18:12:23]

ptal

http://codereview.chromium.org/10830012/diff/1/build/android/ant/chromium-jar...
File build/android/ant/chromium-jars.xml (right):

http://codereview.chromium.org/10830012/diff/1/build/android/ant/chromium-jar...
build/android/ant/chromium-jars.xml:35: description="Compiles source." >
On 2012/07/25 16:57:22, nileshagrawal1 wrote:
> looks like description will fit on the line above.

Done.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/chromium-jar...
build/android/ant/chromium-jars.xml:52: description="Generate
chromium_${PACKAGE_NAME}.jar." >
On 2012/07/25 16:57:22, nileshagrawal1 wrote:
> I think 4 space indent for continuation will make it more distinguishable.
Here
> and elsewhere.

Done.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/chromium-jar...
build/android/ant/chromium-jars.xml:59: description="clean up" >
On 2012/07/25 16:57:22, nileshagrawal1 wrote:
> no line break needed.

Done.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml
File build/android/ant/common.xml (right):

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml#n...
build/android/ant/common.xml:8: <!--
On 2012/07/25 16:57:22, nileshagrawal1 wrote:
> <!-- Common build properties for Chrome for android. -->
> 
> For one line comments?

Done.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml#n...
build/android/ant/common.xml:12: <!-- Macro for checking that a property is
correctly set.
On 2012/07/25 16:57:22, nileshagrawal1 wrote:
> We should settle on one format for multi-line comments.
> What about the format at the top.
> <!--
>   ....
> -->

Done.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml#n...
build/android/ant/common.xml:32: -->
On 2012/07/25 16:57:22, nileshagrawal1 wrote:
> Match this with <!--

Done.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml#n...
build/android/ant/common.xml:37: </condition>
On 2012/07/25 16:57:22, nileshagrawal1 wrote:
> fix indent.

Done.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/common.xml#n...
build/android/ant/common.xml:45: -->
On 2012/07/25 16:57:22, nileshagrawal1 wrote:
> This has a different indentation than the comments at the top.

Done.

http://codereview.chromium.org/10830012/diff/1/build/android/ant/sdk-targets.xml
File build/android/ant/sdk-targets.xml (right):

http://codereview.chromium.org/10830012/diff/1/build/android/ant/sdk-targets....
build/android/ant/sdk-targets.xml:24: <isreference
refid="javac.custom.sourcepath" />
On 2012/07/25 16:57:22, nileshagrawal1 wrote:
> This file has 4-space indent. Looks very different from other files.

Done.

http://codereview.chromium.org/10830012/diff/1/chrome/android/java/chrome.xml
File chrome/android/java/chrome.xml (right):

http://codereview.chromium.org/10830012/diff/1/chrome/android/java/chrome.xml...
chrome/android/java/chrome.xml:3: Use of this source code is governed by a
BSD-style license that can be
On 2012/07/25 16:57:22, nileshagrawal1 wrote:
> Comment format.

Done.

[nilesh, 2012-07-25 18:19:39]

LGTM.
Thanks for fixing everything. A couple of minor nits.

http://codereview.chromium.org/10830012/diff/9001/chrome/chrome.gyp
File chrome/chrome.gyp (right):

http://codereview.chromium.org/10830012/diff/9001/chrome/chrome.gyp#newcode1074
chrome/chrome.gyp:1074: '../net/net.gyp:net_java',
sort.

http://codereview.chromium.org/10830012/diff/9001/chrome/chrome.gyp#newcode1084
chrome/chrome.gyp:1084: ], #OS=="android"
space after #

[Yaron, 2012-07-25 18:34:33]

jrg: need OWNERS stamp (apparently you didn't add me to a few owners files)

[Yaron, 2012-07-25 18:59:16]

hmm. the new configs require sdk tools version 20 so this might have to wait
until we can guarantee all the bots are on 20 and not 19

[John Grabowski, 2012-07-25 21:50:13]

On 2012/07/25 18:59:16, Yaron wrote:
> hmm. the new configs require sdk tools version 20 so this might have to wait
> until we can guarantee all the bots are on 20 and not 19

Yaron: send me a CL that adds you to all OWNERS files I'm in.
You have 130 minutes to comply.

[commit-bot: I haz the power, 2012-07-31 23:16:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10830012/8004

[commit-bot: I haz the power, 2012-07-31 23:16:53]

Presubmit check for 10830012-8004 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome

Presubmit checks took 1.1s to calculate.

[Yaron, 2012-07-31 23:21:11]

ben: can you rubberstamp for chrome/OWNERS

[Yaron, 2012-08-01 23:44:54]

+Torne as this got more interesting due to
http://codereview.chromium.org/10821105/.

Ok, ptal Nilesh/Torne for correctness. Unfortunately, as we discussed this
morning, due to the SDK setup being what it is, I had to add several gyp defines
and change the native test runner to accept multiple environment variable
defines. This should get better if we switch downstream to a checked in SDK/NDK
as well as we can script it to setup the directories appropriately.

jam: can you rubberstamp for owners  content/content_shell.gypi,
content/content_tests.gypi, chrome/chrome.gyp, chrome/chrome_tests.gypi

Also, there'll be a lot less places to update after Chris finishes
crbug.com/136756

[nilesh, 2012-08-02 00:13:12]

LGTM

http://codereview.chromium.org/10830012/diff/9027/testing/android/native_test...
File testing/android/native_test_apk.xml (right):

http://codereview.chromium.org/10830012/diff/9027/testing/android/native_test...
testing/android/native_test_apk.xml:15: TODO(yfriedman): This target can be
invoked from multiple depths. So we use ${PRODUCT_DIR} to normalize the paths.
This could be cleaned up.
 >100 chars.

[shashi, 2012-08-02 01:46:25]

lgtm

[Yaron, 2012-08-02 01:56:56]

On 2012/08/02 01:46:25, shashi wrote:
> lgtm

The try failure is addressed by having
https://bugs.webkit.org/show_bug.cgi?id=92931 land in WebKit first.

[Yaron, 2012-08-06 16:11:20]

On 2012/08/02 01:56:56, Yaron wrote:
> On 2012/08/02 01:46:25, shashi wrote:
> > lgtm
> 
> The try failure is addressed by having
> https://bugs.webkit.org/show_bug.cgi?id=92931 land in WebKit first.

Ok, the webkit changes are all rolled. The last remaining issue is a legitimate
build failure because someone checked in broken code :/

Fixing that right now. Still need a content/chrome rubberstamp

[jam, 2012-08-06 19:03:15]

lgtm

[commit-bot: I haz the power, 2012-08-06 20:13:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10830012/10005

[commit-bot: I haz the power, 2012-08-06 20:44:30]

Try job failure for 10830012-10005 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-06 20:45:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10830012/10005

[commit-bot: I haz the power, 2012-08-06 21:58:54]

Try job failure for 10830012-10005 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2012-08-06 22:09:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yfriedman@chromium.org/10830012/10005

[commit-bot: I haz the power, 2012-08-06 22:52:10]

Try job failure for 10830012-10005 (retry) on linux_chromeos for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[f(malita), 2012-08-11 14:51:18]

This seems to be causing Android build failures after rolling the CR deps:

http://build.webkit.org/builders/Chromium%20Android%20Release/builds/23333/st...


BUILD FAILED
/mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/out/Release/DumpRenderTree_apk/native_test_apk.xml:17:
Cannot find
/mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/build/android/ant/common.xml
imported from
/mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/out/Release/DumpRenderTree_apk/native_test_apk.xml

[Yaron, 2012-08-11 18:18:18]

On 2012/08/11 14:51:18, Florin Malita wrote:
> This seems to be causing Android build failures after rolling the CR deps:
> 
>
http://build.webkit.org/builders/Chromium%2520Android%2520Release/builds/2333...
> 
> 
> BUILD FAILED
>
/mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/out/Release/DumpRenderTree_apk/native_test_apk.xml:17:
> Cannot find
>
/mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/build/android/ant/common.xml
> imported from
>
/mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/out/Release/DumpRenderTree_apk/native_test_apk.xml

Hrmm. That's puzzling as the files are clearly in this CL and the path listed
should exist. However, there were other issues with the roll about the path not
being set correctly. Maybe there's a common problem (see #chromium from last
night)

[Yaron, 2012-08-11 18:21:09]

On 2012/08/11 18:18:18, Yaron wrote:
> On 2012/08/11 14:51:18, Florin Malita wrote:
> > This seems to be causing Android build failures after rolling the CR deps:
> > 
> >
>
http://build.webkit.org/builders/Chromium%252520Android%252520Release/builds/...
> > 
> > 
> > BUILD FAILED
> >
>
/mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/out/Release/DumpRenderTree_apk/native_test_apk.xml:17:
> > Cannot find
> >
>
/mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/build/android/ant/common.xml
> > imported from
> >
>
/mnt/data/b/WebKit-BuildSlave/chromium-linux-android/build/out/Release/DumpRenderTree_apk/native_test_apk.xml
> 
> Hrmm. That's puzzling as the files are clearly in this CL and the path listed
> should exist. However, there were other issues with the roll about the path
not
> being set correctly. Maybe there's a common problem (see #chromium from last
> night)

Looks like Peter already has a proposed fix:
https://chromiumcodereview.appspot.com/10829291/