Issue 10830007: Fixed extension docs PRESUBMIT script when uploading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10830007: Fixed extension docs PRESUBMIT script when uploading. (Closed)

Created:
8 years, 5 months ago by Joao da Silva

Modified:
8 years, 5 months ago

Reviewers:
Aaron Boodman

CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fixed extension docs PRESUBMIT script when uploading. Similar to http://crrev.com/148150, but only triggers when uploading. TBR=aa@chromium.org BUG=111465, 92466 TEST=Uploading CLs that update the extensions docs don't trigger the warning anymore Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=148319

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -12 lines)			Patch
	M	chrome/common/extensions/PRESUBMIT.py	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/common/extensions/PRESUBMIT_test.py	View		3 chunks	+23 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

Joao da Silva

Same issue as yesterday, but this one only triggers with git cl presubmit --upload. Hope ...

8 years, 5 months ago (2012-07-25 12:56:07 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10830007/1

8 years, 5 months ago (2012-07-25 12:56:26 UTC) #2

Change committed as 148319