[Chromoting] Introducing refcount-based life time management of the message loops in the service (d…

remoting/base/auto_thread.cc

Index: remoting/base/auto_thread.cc
diff --git a/remoting/base/auto_thread.cc b/remoting/base/auto_thread.cc
new file mode 100644
index 0000000000000000000000000000000000000000..318be544e721abe88d976896af8990715f5786b1
--- /dev/null
+++ b/remoting/base/auto_thread.cc
@@ -0,0 +1,55 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "remoting/base/auto_thread.h"
+
+#include "base/logging.h"
+#include "base/message_loop.h"
+
+namespace remoting {
+
+AutoThread::AutoThread(const char* name,
+                       scoped_refptr<base::SingleThreadTaskRunner> parent)
+    : parent_(parent),
+      thread_(name) {
+}
+
+bool AutoThread::Start() {
+  return thread_.Start();
+}
+
+bool AutoThread::StartWithOptions(const base::Thread::Options& options) {
+  return thread_.StartWithOptions(options);
+}
+
+bool AutoThread::PostDelayedTask(
+    const tracked_objects::Location& from_here,
+    const base::Closure& task,
+    base::TimeDelta delay) {
+  thread_.message_loop()->PostDelayedTask(from_here, task, delay);
+  return true;
+}
+
+bool AutoThread::PostNonNestableDelayedTask(
+    const tracked_objects::Location& from_here,
+    const base::Closure& task,
+    base::TimeDelta delay) {
+  thread_.message_loop()->PostNonNestableDelayedTask(from_here, task, delay);
+  return true;
+}
+
+bool AutoThread::RunsTasksOnCurrentThread() const {
+  return MessageLoop::current() == thread_.message_loop();
+}
+
+void AutoThread::OnDestruct() const {
+  // Deletes |this| on the parent message loop.
+  parent_->DeleteSoon(FROM_HERE, this);
+}
+
+AutoThread::~AutoThread() {
+  thread_.Stop();

[Wez, 2012/08/24 21:30:49]

This arrangement means that once no-one needs the AutoThread any more the parent
will try to stop & join it, which may cause the parent to be blocked if the
thread is processing a long-lived task at the time; I don't think that's what we
want here.

[alexeypa (please no reviews), 2012/08/27 21:19:40]

Yeah, it is not good. Taking |thread_| owneship from |AutoThread| turned our to
be a tricky business though. I ended up hiding logic responsible for stopping a
message loop behind a callback.

+}
+
+}  // namespace remoting