Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: remoting/host/chromoting_host_context.h

Issue 10829467: [Chromoting] Introducing refcount-based life time management of the message loops in the service (d… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: CR feedback Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/host/chromoting_host_context.h
diff --git a/remoting/host/chromoting_host_context.h b/remoting/host/chromoting_host_context.h
index 2e3480d69d3a1c50f59421615d2aad0d494ce494..07d4c302bf1962769eba8171921105fae0ac087d 100644
--- a/remoting/host/chromoting_host_context.h
+++ b/remoting/host/chromoting_host_context.h
@@ -5,17 +5,11 @@
#ifndef REMOTING_HOST_CHROMOTING_HOST_CONTEXT_H_
#define REMOTING_HOST_CHROMOTING_HOST_CONTEXT_H_
-#include <string>
-
#include "base/gtest_prod_util.h"
#include "base/memory/ref_counted.h"
-#include "base/threading/platform_thread.h"
+#include "base/single_thread_task_runner.h"
#include "base/threading/thread.h"
-namespace base {
-class SingleThreadTaskRunner;
-} // namespace base
-
namespace net {
class URLRequestContextGetter;
} // namespace net
@@ -27,8 +21,7 @@ namespace remoting {
class ChromotingHostContext {
public:
// Create a context.
- ChromotingHostContext(
- scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);
+ ChromotingHostContext(base::SingleThreadTaskRunner* ui_task_runner);
virtual ~ChromotingHostContext();
// TODO(ajwong): Move the Start method out of this class. Then
@@ -86,6 +79,14 @@ class ChromotingHostContext {
// Thread for blocking IO operations.
base::Thread file_thread_;
+ // Task runners wrapping the above threads. These should be declaed after
Wez 2012/08/28 17:34:53 typo: declared
alexeypa (please no reviews) 2012/08/28 19:18:51 Done.
+ // the corresponding threads to guarantee proper order or destruction.
Wez 2012/08/28 17:34:53 typo: of
alexeypa (please no reviews) 2012/08/28 19:18:51 Done. But it sounds funnier with "or". :-)
+ scoped_refptr<base::SingleThreadTaskRunner> network_task_runner_;
+ scoped_refptr<base::SingleThreadTaskRunner> capture_task_runner_;
+ scoped_refptr<base::SingleThreadTaskRunner> encode_task_runner_;
+ scoped_refptr<base::SingleThreadTaskRunner> desktop_task_runner_;
+ scoped_refptr<base::SingleThreadTaskRunner> file_task_runner_;
+
scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;

Powered by Google App Engine
This is Rietveld 408576698