[Chromoting] Introducing refcount-based life time management of the message loops in the service (d…

remoting/host/chromoting_host_context.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/chromoting_host_context.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/threading/thread.h"
+#include "remoting/base/auto_thread_task_runner.h"
 #include "remoting/host/url_request_context.h"
 
 namespace remoting {
 
 ChromotingHostContext::ChromotingHostContext(
     scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner)
     : network_thread_("ChromotingNetworkThread"),
       capture_thread_("ChromotingCaptureThread"),
       encode_thread_("ChromotingEncodeThread"),
       desktop_thread_("ChromotingDesktopThread"),
       file_thread_("ChromotingFileIOThread"),
       ui_task_runner_(ui_task_runner) {
 }
 
 ChromotingHostContext::~ChromotingHostContext() {
 }
 
 bool ChromotingHostContext::Start() {
   // Start all the threads.
   bool started = capture_thread_.Start() && encode_thread_.Start() &&
       network_thread_.StartWithOptions(base::Thread::Options(
           MessageLoop::TYPE_IO, 0)) &&
       desktop_thread_.Start() &&
       file_thread_.StartWithOptions(
           base::Thread::Options(MessageLoop::TYPE_IO, 0));
   if (!started)
     return false;
 
+  // Wrap worker threads to |AutoThreadTaskRunner| two keep the main thread

[Wez, 2012/08/30 23:56:43]

nit: "Wrap worker threads with |AutoThreadTaskRunner| and have them reference
the main thread via |ui_task_runner_|, to ensure that it remain active to Stop()
them when no references remain. This requires that |ui_task_runner_| wraps the
main thread via AutoThreadTaskRunner or equivalent."

[alexeypa (please no reviews), 2012/08/31 19:57:36]

Done. I removed the last sentence because it is now apparent from the
|ui_task_runner_|'s type.

+  // alive until there are references to them.
+  network_task_runner_ =
+      new AutoThreadTaskRunner(network_thread_.message_loop_proxy(),
+                               ui_task_runner_);
+  capture_task_runner_ =
+      new AutoThreadTaskRunner(capture_thread_.message_loop_proxy(),
+                               ui_task_runner_);
+  encode_task_runner_ =
+      new AutoThreadTaskRunner(encode_thread_.message_loop_proxy(),
+                               ui_task_runner_);
+  desktop_task_runner_ =
+      new AutoThreadTaskRunner(desktop_thread_.message_loop_proxy(),
+                               ui_task_runner_);
+  file_task_runner_ =
+      new AutoThreadTaskRunner(file_thread_.message_loop_proxy(),
+                               ui_task_runner_);
+
   url_request_context_getter_ = new URLRequestContextGetter(
       ui_task_runner(), network_task_runner(),
       static_cast<MessageLoopForIO*>(file_thread_.message_loop()));
   return true;
 }
 
+void ChromotingHostContext::Stop() {
+  url_request_context_getter_ = NULL;
+  network_task_runner_ = NULL;
+  capture_task_runner_ = NULL;
+  encode_task_runner_ = NULL;
+  desktop_task_runner_ = NULL;
+  file_task_runner_ = NULL;
+  ui_task_runner_ = NULL;
+}
+
 base::SingleThreadTaskRunner* ChromotingHostContext::capture_task_runner() {
-  return capture_thread_.message_loop_proxy();
+  return capture_task_runner_;
 }
 
 base::SingleThreadTaskRunner* ChromotingHostContext::encode_task_runner() {
-  return encode_thread_.message_loop_proxy();
+  return encode_task_runner_;
 }
 
 base::SingleThreadTaskRunner* ChromotingHostContext::network_task_runner() {
-  return network_thread_.message_loop_proxy();
+  return network_task_runner_;
 }
 
 base::SingleThreadTaskRunner* ChromotingHostContext::desktop_task_runner() {
-  return desktop_thread_.message_loop_proxy();
+  return desktop_task_runner_;
 }
 
 base::SingleThreadTaskRunner* ChromotingHostContext::ui_task_runner() {
   return ui_task_runner_;
 }
 
 base::SingleThreadTaskRunner* ChromotingHostContext::file_task_runner() {
-  return file_thread_.message_loop_proxy();
+  return file_task_runner_;
 }
 
 const scoped_refptr<net::URLRequestContextGetter>&
 ChromotingHostContext::url_request_context_getter() {
   DCHECK(url_request_context_getter_.get());
   return url_request_context_getter_;
 }
 
 }  // namespace remoting