[Chromoting] Introducing refcount-based life time management of the message loops in the service (d…

remoting/host/chromoting_host_context.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_HOST_CHROMOTING_HOST_CONTEXT_H_
 #define REMOTING_HOST_CHROMOTING_HOST_CONTEXT_H_
 
-#include <string>
-
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
-#include "base/threading/platform_thread.h"
+#include "base/single_thread_task_runner.h"
 #include "base/threading/thread.h"
 
-namespace base {
-class SingleThreadTaskRunner;
-}  // namespace base
-
 namespace net {
 class URLRequestContextGetter;
 }  // namespace net
 
 namespace remoting {
 
 // A class that manages threads and running context for the chromoting host
 // process.  This class is virtual only for testing purposes (see below).
 class ChromotingHostContext {
  public:
   // Create a context.
-  ChromotingHostContext(
-      scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner);
+  ChromotingHostContext(base::SingleThreadTaskRunner* ui_task_runner);

[Wez, 2012/08/30 18:25:41]

This should remain scoped_refptr<> to implicitly document the object's lifetime.

   virtual ~ChromotingHostContext();
 
   // TODO(ajwong): Move the Start method out of this class. Then
   // create a static factory for construction, and destruction.  We
   // should be able to remove the need for virtual functions below
   // with that design, while preserving the relative simplicity of
   // this API.
   virtual bool Start();
 
   // Task runner for the thread that is used for the UI. In the NPAPI
@@ skipping 37 matching lines @@
 
   // A thread that hosts all encode operations.
   base::Thread encode_thread_;
 
   // A thread that hosts input injection.
   base::Thread desktop_thread_;
 
   // Thread for blocking IO operations.
   base::Thread file_thread_;
 
+  // Task runners wrapping the above threads. These should be declared after
+  // the corresponding threads to guarantee proper order of destruction.
+  scoped_refptr<base::SingleThreadTaskRunner> network_task_runner_;
+  scoped_refptr<base::SingleThreadTaskRunner> capture_task_runner_;
+  scoped_refptr<base::SingleThreadTaskRunner> encode_task_runner_;
+  scoped_refptr<base::SingleThreadTaskRunner> desktop_task_runner_;
+  scoped_refptr<base::SingleThreadTaskRunner> file_task_runner_;
+
   scoped_refptr<base::SingleThreadTaskRunner> ui_task_runner_;
 
   scoped_refptr<net::URLRequestContextGetter> url_request_context_getter_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromotingHostContext);
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_HOST_CHROMOTING_HOST_CONTEXT_H_