Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: chrome/test/base/uma_histogram_helper.h

Issue 10829466: SampleSet -> HistogramSamples (will be reused by SparseHistogram) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/metrics/metrics_service_base.cc ('k') | chrome/test/base/uma_histogram_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/uma_histogram_helper.h
===================================================================
--- chrome/test/base/uma_histogram_helper.h (revision 158017)
+++ chrome/test/base/uma_histogram_helper.h (working copy)
@@ -6,6 +6,8 @@
#define CHROME_TEST_BASE_UMA_HISTOGRAM_HELPER_H_
#include "base/metrics/histogram.h"
+#include "base/metrics/histogram_base.h"
+#include "base/metrics/histogram_samples.h"
// UMAHistogramHelper provides a simple interface for examining UMA histograms.
// Tests can use this interface to verify that UMA data is getting logged as
@@ -20,22 +22,25 @@
// We know the exact number of samples in a bucket, and that no other bucket
// should have samples.
- void ExpectUniqueSample(const std::string& name, size_t bucket_id,
- base::Histogram::Count expected_count);
+ void ExpectUniqueSample(const std::string& name,
+ base::HistogramBase::Sample sample,
+ base::HistogramBase::Count expected_count);
// We don't know the values of the samples, but we know how many there are.
- void ExpectTotalCount(const std::string& name, base::Histogram::Count count);
+ void ExpectTotalCount(const std::string& name,
+ base::HistogramBase::Count count);
private:
void FetchCallback();
- void CheckBucketCount(const std::string& name, size_t bucket_id,
+ void CheckBucketCount(const std::string& name,
+ base::HistogramBase::Sample sample,
base::Histogram::Count expected_count,
- base::Histogram::SampleSet& samples);
+ base::HistogramSamples& samples);
void CheckTotalCount(const std::string& name,
base::Histogram::Count expected_count,
- base::Histogram::SampleSet& samples);
+ base::HistogramSamples& samples);
DISALLOW_COPY_AND_ASSIGN(UMAHistogramHelper);
};
« no previous file with comments | « chrome/common/metrics/metrics_service_base.cc ('k') | chrome/test/base/uma_histogram_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698