chrome/browser/protector/default_search_provider_change_browsertest.cc - Issue 10829466: SampleSet -> HistogramSamples (will be reused by SparseHistogram)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/protector/default_search_provider_change_browsertest.cc

Issue 10829466: SampleSet -> HistogramSamples (will be reused by SparseHistogram) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/protector/default_search_provider_change_browsertest.cc

===================================================================

--- chrome/browser/protector/default_search_provider_change_browsertest.cc (revision 155400)

+++ chrome/browser/protector/default_search_provider_change_browsertest.cc (working copy)

@@ -4,6 +4,7 @@

#include "base/memory/scoped_ptr.h"

#include "base/metrics/histogram.h"

+#include "base/metrics/sample_vector.h"

#include "base/metrics/statistics_recorder.h"

#include "base/message_loop.h"

#include "base/utf_string_conversions.h"

@@ -130,10 +131,9 @@

base::Histogram::Count count) {

base::Histogram* histogram = base::StatisticsRecorder::FindHistogram(name);

EXPECT_TRUE(histogram != NULL);

- base::Histogram::SampleSet sample;

- histogram->SnapshotSample(&sample);

- EXPECT_EQ(count, sample.counts(bucket)) <<

- "Invalid " << name << " value for bucket " << bucket;

+ scoped_ptr<base::SampleVector> samples = histogram->SnapshotSamples();

+ EXPECT_EQ(count, samples->GetCountAtIndex(bucket))

+ << "Invalid " << name << " value for bucket " << bucket;

}

protected: