Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Unified Diff: chrome/browser/chrome_browser_application_mac_unittest.mm

Issue 10829466: SampleSet -> HistogramSamples (will be reused by SparseHistogram) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_application_mac_unittest.mm
===================================================================
--- chrome/browser/chrome_browser_application_mac_unittest.mm (revision 152603)
+++ chrome/browser/chrome_browser_application_mac_unittest.mm (working copy)
@@ -5,12 +5,14 @@
#import <Cocoa/Cocoa.h>
#import "base/mac/scoped_nsexception_enabler.h"
+#include "base/memory/scoped_ptr.h"
#include "base/metrics/histogram.h"
#include "base/metrics/statistics_recorder.h"
#import "chrome/browser/chrome_browser_application_mac.h"
#include "testing/gtest/include/gtest/gtest.h"
using base::Histogram;
+using base::HistogramSamples;
using base::StatisticsRecorder;
namespace chrome_browser_application_mac {
@@ -74,16 +76,16 @@
StatisticsRecorder::GetSnapshot("OSX.NSException", &histograms);
EXPECT_EQ(1U, histograms.size());
EXPECT_EQ(Histogram::kUmaTargetedHistogramFlag, histograms[0]->flags());
- Histogram::SampleSet sample;
- histograms[0]->SnapshotSample(&sample);
- EXPECT_EQ(4, sample.counts(0));
- EXPECT_EQ(1, sample.counts(1));
- EXPECT_EQ(3, sample.counts(2));
- EXPECT_EQ(2, sample.counts(3));
+ scoped_ptr<HistogramSamples> samples(histograms[0]->SnapshotSamples());
+ EXPECT_EQ(4, samples->GetCount(0));
+ EXPECT_EQ(1, samples->GetCount(1));
+ EXPECT_EQ(3, samples->GetCount(2));
+ EXPECT_EQ(2, samples->GetCount(3));
+
// The unknown exceptions should end up in the overflow bucket.
EXPECT_EQ(kUnknownNSException + 1, histograms[0]->bucket_count());
- EXPECT_EQ(4, sample.counts(kUnknownNSException));
+ EXPECT_EQ(4, samples->GetCount(kUnknownNSException));
}
} // chrome_browser_application_mac

Powered by Google App Engine
This is Rietveld 408576698