Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: base/metrics/histogram_flattener.h

Issue 10829466: SampleSet -> HistogramSamples (will be reused by SparseHistogram) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « base/metrics/histogram.cc ('k') | base/metrics/histogram_samples.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_METRICS_HISTOGRAM_FLATTENER_H_ 5 #ifndef BASE_METRICS_HISTOGRAM_FLATTENER_H_
6 #define BASE_METRICS_HISTOGRAM_FLATTENER_H_ 6 #define BASE_METRICS_HISTOGRAM_FLATTENER_H_
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
11 #include "base/basictypes.h" 11 #include "base/basictypes.h"
12 #include "base/memory/scoped_ptr.h" 12 #include "base/memory/scoped_ptr.h"
13 #include "base/metrics/histogram.h" 13 #include "base/metrics/histogram.h"
14 14
15 namespace base { 15 namespace base {
16 16
17 class HistogramSamples;
18
17 // HistogramFlattener is an interface used by HistogramSnapshotManager, which 19 // HistogramFlattener is an interface used by HistogramSnapshotManager, which
18 // handles the logistics of gathering up available histograms for recording. 20 // handles the logistics of gathering up available histograms for recording.
19 // The implementors handle the exact lower level recording mechanism, or 21 // The implementors handle the exact lower level recording mechanism, or
20 // error report mechanism. 22 // error report mechanism.
21 class BASE_EXPORT HistogramFlattener { 23 class BASE_EXPORT HistogramFlattener {
22 public: 24 public:
23 virtual void RecordDelta(const base::Histogram& histogram, 25 virtual void RecordDelta(const Histogram& histogram,
24 const base::Histogram::SampleSet& snapshot) = 0; 26 const HistogramSamples& snapshot) = 0;
25 27
26 // Will be called each time a type of Inconsistenies is seen on a histogram, 28 // Will be called each time a type of Inconsistenies is seen on a histogram,
27 // during inspections done internally in HistogramSnapshotManager class. 29 // during inspections done internally in HistogramSnapshotManager class.
28 virtual void InconsistencyDetected(Histogram::Inconsistencies problem) = 0; 30 virtual void InconsistencyDetected(Histogram::Inconsistencies problem) = 0;
29 31
30 // Will be called when a type of Inconsistenies is seen for the first time 32 // Will be called when a type of Inconsistenies is seen for the first time
31 // on a histogram. 33 // on a histogram.
32 virtual void UniqueInconsistencyDetected( 34 virtual void UniqueInconsistencyDetected(
33 Histogram::Inconsistencies problem) = 0; 35 Histogram::Inconsistencies problem) = 0;
34 36
35 // Will be called when the total logged sample count of a histogram 37 // Will be called when the total logged sample count of a histogram
36 // differs from the sum of logged sample count in all the buckets. The 38 // differs from the sum of logged sample count in all the buckets. The
37 // argument |amount| is the non-zero discrepancy. 39 // argument |amount| is the non-zero discrepancy.
38 virtual void InconsistencyDetectedInLoggedCount(int amount) = 0; 40 virtual void InconsistencyDetectedInLoggedCount(int amount) = 0;
39 41
40 protected: 42 protected:
41 HistogramFlattener() {} 43 HistogramFlattener() {}
42 virtual ~HistogramFlattener() {} 44 virtual ~HistogramFlattener() {}
43 45
44 private: 46 private:
45 DISALLOW_COPY_AND_ASSIGN(HistogramFlattener); 47 DISALLOW_COPY_AND_ASSIGN(HistogramFlattener);
46 }; 48 };
47 49
48 } // namespace base 50 } // namespace base
49 51
50 #endif // BASE_METRICS_HISTOGRAM_FLATTENER_H_ 52 #endif // BASE_METRICS_HISTOGRAM_FLATTENER_H_
OLDNEW
« no previous file with comments | « base/metrics/histogram.cc ('k') | base/metrics/histogram_samples.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698