Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 10829465: Apply frame-src content-security-policy to WebUI pages. (Closed)

Created:
8 years, 4 months ago by Tom Sepez
Modified:
8 years, 3 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Apply frame-src content-security-policy to WebUI pages. BUG=143003 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153520

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -13 lines) Patch
M chrome/browser/ui/webui/chrome_url_data_manager_backend.cc View 1 2 2 chunks +36 lines, -13 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tom Sepez
Adds the frame-src directive to WebUI Content-security-policies, provding for exceptions. Also converts the execption mechanism ...
8 years, 4 months ago (2012-08-21 19:46:24 UTC) #1
Evan Stade
lgtm
8 years, 4 months ago (2012-08-21 20:56:21 UTC) #2
Evan Stade
http://codereview.chromium.org/10829465/diff/2002/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc File chrome/browser/ui/webui/chrome_url_data_manager_backend.cc (right): http://codereview.chromium.org/10829465/diff/2002/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc#newcode92 chrome/browser/ui/webui/chrome_url_data_manager_backend.cc:92: // applied to the WebUI page. documentation for what ...
8 years, 4 months ago (2012-08-21 20:56:26 UTC) #3
Tom Sepez
On 2012/08/21 20:56:26, Evan Stade wrote: > http://codereview.chromium.org/10829465/diff/2002/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc > File chrome/browser/ui/webui/chrome_url_data_manager_backend.cc (right): > > http://codereview.chromium.org/10829465/diff/2002/chrome/browser/ui/webui/chrome_url_data_manager_backend.cc#newcode92 ...
8 years, 4 months ago (2012-08-21 21:31:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/10829465/4
8 years, 3 months ago (2012-08-27 17:05:33 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-08-27 19:31:51 UTC) #6
Change committed as 153520

Powered by Google App Engine
This is Rietveld 408576698