Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(552)

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10829462: Improve the problem description. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/dom/scripts/systemnative.py
diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py
index 3f086f6257113bec7ae3a8d93c89e814f6fc35a0..0b1979d5743cff49656d1e67fc874e576336cc6d 100644
--- a/lib/dom/scripts/systemnative.py
+++ b/lib/dom/scripts/systemnative.py
@@ -665,7 +665,8 @@ class NativeImplementationGenerator(systembase.BaseGenerator):
if self._IsArgumentOptionalInWebCore(operation, argument):
check = '%s !== _null' % argument_names[position]
# argument_count instead of position + 1 is used here to cover one
- # complicated case. Consider foo(x, [Optional] y, [Optional=DefaultIsNullString] z)
+ # complicated case with the effectively optional argument in the middle.
+ # Consider foo(x, [Optional] y, [Optional=DefaultIsNullString] z)
# (as of now it's modelled after HTMLMediaElement.webkitAddKey).
# y is optional in WebCore, while z is not.
# In this case, if y !== _null, we'd like to emit foo(x, y, z) invocation, not
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698