utils/tests/pub/test_pub.dart - Issue 10829459: Deprecate Math object in corelib in favor of dart:math library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/tests/pub/test_pub.dart

Issue 10829459: Deprecate Math object in corelib in favor of dart:math library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: utils/tests/pub/test_pub.dart

diff --git a/utils/tests/pub/test_pub.dart b/utils/tests/pub/test_pub.dart

index 9e8e9d373d0d40e05b10400f2673a2ff11e7311d..d272cb7f026b891f2dd58947330d164618d3723a 100644

--- a/utils/tests/pub/test_pub.dart

+++ b/utils/tests/pub/test_pub.dart

@@ -13,6 +13,7 @@

#import('dart:io');

#import('dart:isolate');

#import('dart:json');

+#import('dart:math');

#import('dart:uri');

#import('../../../pkg/unittest/unittest.dart');

@@ -364,7 +365,7 @@ void _validateOutputString(String expectedText, List<String> actual) {

// to expect zero lines of output, not a single empty line.

expected.removeLast();

- final length = Math.min(expected.length, actual.length);

+ final length = min(expected.length, actual.length);

for (var i = 0; i < length; i++) {

if (expected[i].trim() != actual[i].trim()) {

Expect.fail(

« no previous file with comments | « utils/template/template.dart ('k') | utils/tests/pub/yaml_test.dart » ('j') | no next file with comments »