utils/pub/version_solver.dart - Issue 10829459: Deprecate Math object in corelib in favor of dart:math library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/version_solver.dart

Issue 10829459: Deprecate Math object in corelib in favor of dart:math library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: utils/pub/version_solver.dart

diff --git a/utils/pub/version_solver.dart b/utils/pub/version_solver.dart

index cd817cfbdbca5195494d24fcf25c31c87758570a..2aadbfa8d7c8bab613e8cee24ada93cd679a284d 100644

--- a/utils/pub/version_solver.dart

+++ b/utils/pub/version_solver.dart

@@ -38,6 +38,7 @@

#library('version_solver');

#import('dart:json');

+#import('dart:math');

#import('lock_file.dart');

#import('package.dart');

#import('pubspec.dart');

@@ -108,7 +109,7 @@ class VersionSolver {

// TODO(rnystrom): These numbers here are magic and arbitrary. Tune

// when we have a better picture of real-world package topologies.

_numIterations++;

- if (_numIterations > Math.max(50, _packages.length * 5)) {

+ if (_numIterations > max(50, _packages.length * 5)) {

throw new CouldNotSolveException();

}

« no previous file with comments | « utils/pub/version.dart ('k') | utils/pub/yaml/yaml.dart » ('j') | no next file with comments »