runtime/bin/file_impl.dart - Issue 10829459: Deprecate Math object in corelib in favor of dart:math library.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/file_impl.dart

Issue 10829459: Deprecate Math object in corelib in favor of dart:math library. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address review comments. Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/file_impl.dart

diff --git a/runtime/bin/file_impl.dart b/runtime/bin/file_impl.dart

index 9b14716e92e25aaa911e56e31784a39a9a4cf135..69add2dbbafc0d9dbf325fa0dde1839668100580 100644

--- a/runtime/bin/file_impl.dart

+++ b/runtime/bin/file_impl.dart

@@ -60,7 +60,7 @@ class _FileInputStream extends _BaseDataInputStream implements InputStream {

void _fillBuffer() {

Expect.equals(_position, _data.length);

if (_openedFile == null) return; // Called before the file is opened.

- int size = Math.min(_bufferLength, _fileLength - _filePosition);

+ int size = min(_bufferLength, _fileLength - _filePosition);

if (size == 0) {

_closeFile();

return;

« no previous file with comments | « pkg/unittest/interactive_html_config.dart ('k') | runtime/bin/http_impl.dart » ('j') | no next file with comments »