Clarified description of the timezone policy.

Clarified description of the timezone policy.

Refining this CL: http://codereview.chromium.org/10832222/

TBR=nirnimesh@chromium.org
BUG=chromium-os:27206
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=153022

[pneubeck (no reviews), 2012-08-21 08:43:58]

Please review.

[Mattias Nissler (ping if slow), 2012-08-21 08:48:20]

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/app/policy/poli...
File chrome/app/policy/policy_templates.json (right):

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/app/policy/poli...
chrome/app/policy/policy_templates.json:3180: If this policy is not used, the
currently active timezone will remain in use however users can change the
timezone and the change is persistent. Thus a change of one user affects the
login-screen and all other users.
s/of/by/

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/app/policy/poli...
chrome/app/policy/policy_templates.json:3182: New devices start using the
timezone "US/Pacific".
s/start using the timezone/start out with the timezone set to/.

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/browser/policy/...
File chrome/browser/policy/proto/chrome_device_policy.proto (right):

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/browser/policy/...
chrome/browser/policy/proto/chrome_device_policy.proto:211: // listed in
"timezone_settings.cc". Additionally, timezones from
Re-flow to use all 80 columns.

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/browser/policy/...
chrome/browser/policy/proto/chrome_device_policy.proto:216: // Only if no value
is provided, the timezone policy is inactive.
Please describe what "inactive" means.

[pneubeck (no reviews), 2012-08-21 09:02:10]

Addressed comments.

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/app/policy/poli...
File chrome/app/policy/policy_templates.json (right):

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/app/policy/poli...
chrome/app/policy/policy_templates.json:3180: If this policy is not used, the
currently active timezone will remain in use however users can change the
timezone and the change is persistent. Thus a change of one user affects the
login-screen and all other users.
On 2012/08/21 08:48:20, Mattias Nissler wrote:
> s/of/by/

Done.

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/app/policy/poli...
chrome/app/policy/policy_templates.json:3182: New devices start using the
timezone "US/Pacific".
On 2012/08/21 08:48:20, Mattias Nissler wrote:
> s/start using the timezone/start out with the timezone set to/.

Done.

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/browser/policy/...
File chrome/browser/policy/proto/chrome_device_policy.proto (right):

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/browser/policy/...
chrome/browser/policy/proto/chrome_device_policy.proto:211: // listed in
"timezone_settings.cc". Additionally, timezones from
On 2012/08/21 08:48:20, Mattias Nissler wrote:
> Re-flow to use all 80 columns.

Done.

https://chromiumcodereview.appspot.com/10829449/diff/1/chrome/browser/policy/...
chrome/browser/policy/proto/chrome_device_policy.proto:216: // Only if no value
is provided, the timezone policy is inactive.
On 2012/08/21 08:48:20, Mattias Nissler wrote:
> Please describe what "inactive" means.

Done.

[Mattias Nissler (ping if slow), 2012-08-21 09:06:34]

https://chromiumcodereview.appspot.com/10829449/diff/6001/chrome/browser/poli...
File chrome/browser/policy/proto/chrome_device_policy.proto (right):

https://chromiumcodereview.appspot.com/10829449/diff/6001/chrome/browser/poli...
chrome/browser/policy/proto/chrome_device_policy.proto:210: // The timezone
policy is active if this value is provided. Valid values are
Sorry to nitpick further, I didn't catch this: Can we talk in terms of device
settings instead of policy?

[pneubeck (no reviews), 2012-08-21 09:14:15]

Replaced "policy" by "device settings".

[Mattias Nissler (ping if slow), 2012-08-21 09:19:06]

LGTM. Please give Bin a chance to comment as well.

https://chromiumcodereview.appspot.com/10829449/diff/9001/chrome/browser/poli...
File chrome/browser/policy/proto/chrome_device_policy.proto (right):

https://chromiumcodereview.appspot.com/10829449/diff/9001/chrome/browser/poli...
chrome/browser/policy/proto/chrome_device_policy.proto:210: // The timezone
device setting is active if this value is provided. Valid
One last suggestion: "Specifies an owner-determined timezone that applies to the
login screen and all users."

[pneubeck (no reviews), 2012-08-21 09:24:52]

Addressed the comment.

[Bin, 2012-08-21 17:05:21]

https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/app/policy/p...
File chrome/app/policy/policy_templates.json (right):

https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/app/policy/p...
chrome/app/policy/policy_templates.json:3169: 'name': 'DeviceTimezone',
What's the difference between this and SystemTimezoneProto in the other file?
This is a device_only setting too.

https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/browser/poli...
File chrome/browser/policy/proto/chrome_device_policy.proto (right):

https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/browser/poli...
chrome/browser/policy/proto/chrome_device_policy.proto:216: // Only if no value
is provided, the timezone device setting is inactive. In
No value means the optional value is not set. An empty string is considered as
an invalid value, right? It may worthwhile explicitly stating it out.

[pneubeck (no reviews), 2012-08-22 07:39:40]

Addressed comments.

+nirnimesh, could you please acknowledge the rename in the test file. Thanks.

https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/app/policy/p...
File chrome/app/policy/policy_templates.json (right):

https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/app/policy/p...
chrome/app/policy/policy_templates.json:3169: 'name': 'DeviceTimezone',
On 2012/08/21 17:05:22, binzhao1 wrote:
> What's the difference between this and SystemTimezoneProto in the other file?
> This is a device_only setting too.
No difference. I renamed it to make this clear.

https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/browser/poli...
File chrome/browser/policy/proto/chrome_device_policy.proto (right):

https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/browser/poli...
chrome/browser/policy/proto/chrome_device_policy.proto:216: // Only if no value
is provided, the timezone device setting is inactive. In
On 2012/08/21 17:05:22, binzhao1 wrote:
> No value means the optional value is not set. An empty string is considered as
> an invalid value, right? It may worthwhile explicitly stating it out.

Done.

[Mattias Nissler (ping if slow), 2012-08-22 07:55:35]

On 2012/08/22 07:39:40, pneubeck1 wrote:
> Addressed comments.
> 
> +nirnimesh, could you please acknowledge the rename in the test file. Thanks.

I think it's OK to TBR that and commit the thing :)

> 
>
https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/app/policy/p...
> File chrome/app/policy/policy_templates.json (right):
> 
>
https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/app/policy/p...
> chrome/app/policy/policy_templates.json:3169: 'name': 'DeviceTimezone',
> On 2012/08/21 17:05:22, binzhao1 wrote:
> > What's the difference between this and SystemTimezoneProto in the other
file?
> > This is a device_only setting too.
> No difference. I renamed it to make this clear.
> 
>
https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/browser/poli...
> File chrome/browser/policy/proto/chrome_device_policy.proto (right):
> 
>
https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/browser/poli...
> chrome/browser/policy/proto/chrome_device_policy.proto:216: // Only if no
value
> is provided, the timezone device setting is inactive. In
> On 2012/08/21 17:05:22, binzhao1 wrote:
> > No value means the optional value is not set. An empty string is considered
as
> > an invalid value, right? It may worthwhile explicitly stating it out.
> 
> Done.

[commit-bot: I haz the power, 2012-08-22 07:59:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/10829449/12001

[Nirnimesh, 2012-08-22 08:57:31]

lgtm

On Wednesday, August 22, 2012,  <mnissler@chromium.org> wrote:
> On 2012/08/22 07:39:40, pneubeck1 wrote:
>>
>> Addressed comments.
>
>> +nirnimesh, could you please acknowledge the rename in the test file.
Thanks.
>
> I think it's OK to TBR that and commit the thing :)
>
>
>
>
https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/app/policy/p...
>>
>> File chrome/app/policy/policy_templates.json (right):
>
>
>
https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/app/policy/p...
>>
>> chrome/app/policy/policy_templates.json:3169: 'name': 'DeviceTimezone',
>> On 2012/08/21 17:05:22, binzhao1 wrote:
>> > What's the difference between this and SystemTimezoneProto in the other
>
> file?
>>
>> > This is a device_only setting too.
>> No difference. I renamed it to make this clear.
>
>
>
https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/browser/poli...
>>
>> File chrome/browser/policy/proto/chrome_device_policy.proto (right):
>
>
>
https://chromiumcodereview.appspot.com/10829449/diff/9002/chrome/browser/poli...
>>
>> chrome/browser/policy/proto/chrome_device_policy.proto:216: // Only if no
>
> value
>>
>> is provided, the timezone device setting is inactive. In
>> On 2012/08/21 17:05:22, binzhao1 wrote:
>> > No value means the optional value is not set. An empty string is
considered
>
> as
>>
>> > an invalid value, right? It may worthwhile explicitly stating it out.
>
>> Done.
>
>
>
> https://chromiumcodereview.appspot.com/10829449/
>

-- 
../NiR

[commit-bot: I haz the power, 2012-08-22 09:36:59]

Try job failure for 10829449-12001 (retry) on win for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

[commit-bot: I haz the power, 2012-08-23 09:50:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/10829449/12001

[commit-bot: I haz the power, 2012-08-23 12:43:07]

Try job failure for 10829449-12001 (retry) on win_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-08-23 14:54:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pneubeck@chromium.org/10829449/12001

[commit-bot: I haz the power, 2012-08-23 17:22:02]

Change committed as 153022