Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Unified Diff: vm/raw_object_snapshot.cc

Issue 10829445: Use unreachable in snapshot generation when we do not expect the object to be sent in a message. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/raw_object_snapshot.cc
===================================================================
--- vm/raw_object_snapshot.cc (revision 11004)
+++ vm/raw_object_snapshot.cc (working copy)
@@ -1146,7 +1146,7 @@
intptr_t object_id,
intptr_t tags,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ UNREACHABLE();
return ApiError::null();
}
@@ -1154,7 +1154,7 @@
void RawApiError::WriteTo(SnapshotWriter* writer,
intptr_t object_id,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ UNREACHABLE();
}
@@ -1162,7 +1162,7 @@
intptr_t object_id,
intptr_t tags,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ UNREACHABLE();
return LanguageError::null();
}
@@ -1170,7 +1170,7 @@
void RawLanguageError::WriteTo(SnapshotWriter* writer,
intptr_t object_id,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ UNREACHABLE();
}
@@ -1178,7 +1178,7 @@
intptr_t object_id,
intptr_t tags,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ UNREACHABLE();
return UnhandledException::null();
}
@@ -1186,7 +1186,7 @@
void RawUnhandledException::WriteTo(SnapshotWriter* writer,
intptr_t object_id,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ UNREACHABLE();
}
@@ -1194,7 +1194,7 @@
intptr_t object_id,
intptr_t tags,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ UNREACHABLE();
return UnwindError::null();
}
@@ -1202,7 +1202,7 @@
void RawUnwindError::WriteTo(SnapshotWriter* writer,
intptr_t object_id,
Snapshot::Kind kind) {
- UNIMPLEMENTED();
+ UNREACHABLE();
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698