Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: runtime/vm/port_test.cc

Issue 10829444: Avoid trusting the length encoded in the Snapshot if there is an (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/native_message_handler.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/port_test.cc
===================================================================
--- runtime/vm/port_test.cc (revision 11409)
+++ runtime/vm/port_test.cc (working copy)
@@ -121,8 +121,11 @@
Dart_Port port = PortMap::CreatePort(&handler);
EXPECT_EQ(0, handler.notify_count);
+ const char* message = "msg";
+ intptr_t message_len = strlen(message) + 1;
+
EXPECT(PortMap::PostMessage(new Message(
- port, 0, reinterpret_cast<uint8_t*>(strdup("msg")),
+ port, 0, reinterpret_cast<uint8_t*>(strdup(message)), message_len,
Message::kNormalPriority)));
// Check that the message notify callback was called.
@@ -132,8 +135,11 @@
TEST_CASE(PortMap_PostMessageInvalidPort) {
+ const char* message = "msg";
+ intptr_t message_len = strlen(message) + 1;
+
EXPECT(!PortMap::PostMessage(new Message(
- 0, 0, reinterpret_cast<uint8_t*>(strdup("msg")),
+ 0, 0, reinterpret_cast<uint8_t*>(strdup(message)), message_len,
Message::kNormalPriority)));
}
« no previous file with comments | « runtime/vm/native_message_handler.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698