contacts: Strip Unicode byte order marks from strings.

contacts: Strip Unicode byte order marks from strings.

The feeds that we get from the Contacts API are UTF-8, but
they're littered with BOM characters.  This change makes
GDataContactsService strip out these characters when
initializing contacts::Contact objects.

I'm also merging a few related browser tests together so
that the new test that I'm adding won't increase the total
running time.

BUG=128805
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152389

[satorux1, 2012-08-20 18:37:58]

LGTM with a request:

https://chromiumcodereview.appspot.com/10829435/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_contacts_service_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/10829435/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_contacts_service_browsertest.cc:298: false,
"安藤 忠雄", "忠雄", "", "安藤", "", "",
I think it's safer to escape them. multi-byte characters in source code is
worrisome.

1) not everyone is using UTF-8 capable editors
2) some editors may interpret this based on the current locale, and cause
garbled text.
3) likewise, some compilers may interpret this based on the current locale, and
cause test failures.

Here's a useful too for you.

http://0xcc.net/jsescape/

安藤 忠雄 ->
\xEF\xBB\xBF\xE5\xAE\x89\xE8\x97\xA4\x20\xE5\xBF\xA0\xE9\x9B\x84

[Daniel Erat, 2012-08-20 19:09:43]

https://chromiumcodereview.appspot.com/10829435/diff/1/chrome/browser/chromeo...
File chrome/browser/chromeos/gdata/gdata_contacts_service_browsertest.cc
(right):

https://chromiumcodereview.appspot.com/10829435/diff/1/chrome/browser/chromeo...
chrome/browser/chromeos/gdata/gdata_contacts_service_browsertest.cc:298: false,
"安藤 忠雄", "忠雄", "", "安藤", "", "",
On 2012/08/20 18:37:58, satorux1 wrote:
> I think it's safer to escape them. multi-byte characters in source code is
> worrisome.
> 
> 1) not everyone is using UTF-8 capable editors
> 2) some editors may interpret this based on the current locale, and cause
> garbled text.
> 3) likewise, some compilers may interpret this based on the current locale,
and
> cause test failures.

Sure, was wondering about this too.  Updated.

> Here's a useful too for you.
> 
> http://0xcc.net/jsescape/
> 
> 安藤 忠雄 ->
> \xEF\xBB\xBF\xE5\xAE\x89\xE8\x97\xA4\x20\xE5\xBF\xA0\xE9\x9B\x84

I think you have an unnecessary BOM character at the beginning of this. :-)

[commit-bot: I haz the power, 2012-08-20 19:30:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/derat@chromium.org/10829435/6001

[commit-bot: I haz the power, 2012-08-20 21:00:48]

Change committed as 152389