Issue 10829432: Add key pixel check option in GpuPixelBrowserTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829432: Add key pixel check option in GpuPixelBrowserTest. (Closed)

Created:
8 years, 4 months ago by Zhenyao Mo

Modified:
8 years, 4 months ago

Reviewers:
jbates

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add key pixel check option in GpuPixelBrowserTest. BUG=122861 TEST=gpu bots Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152378

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -27 lines)			Patch
	M	chrome/test/gpu/gpu_pixel_browsertest.cc	View	1	16 chunks	+124 lines, -27 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jbates

8 years, 4 months ago (2012-08-20 19:58:11 UTC) #2

LGTM, couple nits.

https://chromiumcodereview.appspot.com/10829432/diff/1/chrome/test/gpu/gpu_pi...
File chrome/test/gpu/gpu_pixel_browsertest.cc (right):

https://chromiumcodereview.appspot.com/10829432/diff/1/chrome/test/gpu/gpu_pi...
chrome/test/gpu/gpu_pixel_browsertest.cc:407: DCHECK(x >= 0 && x <
gen_bmp.width() && y >= 0 && y < gen_bmp.height());
Since this is test code, instead of DCHECK you should use ASSERT_TRUE (or
combination of ASSERT_* macros).

https://chromiumcodereview.appspot.com/10829432/diff/1/chrome/test/gpu/gpu_pi...
chrome/test/gpu/gpu_pixel_browsertest.cc:411: DCHECK(rgba);
ASSERT_TRUE or ASSERT_NE(rgba, NULL)

Expand Messages | Collapse Messages