Issue 10829428: [cros] Fix UserImagesGrid display regression.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10829428: [cros] Fix UserImagesGrid display regression. (Closed)

Created:
8 years, 4 months ago by Ivan Korotkov

Modified:
8 years, 4 months ago

Reviewers:
ygorshenin1

CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, pneubeck (no reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros] Fix UserImagesGrid display regression. *) Set autoExpands=true for UserImagesGrid so that added items are actually created (regression after ). *) Typo fix for old UI, which prevented it from working. TBR=ygorshenin1 BUG=None TEST=Manual: chrome://chrome/settings/changePicture should display the image grid properly Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152334

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	chrome/browser/resources/chromeos/login/oobe_screen_user_image.js	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/resources/chromeos/user_images_grid.js	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages