Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 10829421: First cut of the updated Photo Editor UI (Closed)

Created:
8 years, 4 months ago by Vladislav Kaznacheev
Modified:
8 years, 3 months ago
Reviewers:
dgozman
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, nkostylev+watch_chromium.org, Aaron Boodman, rginda+watch_chromium.org, arv (Not doing code reviews), oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

First cut of the updated Photo Editor UI Limitations: - "mosaic" is a stub based on standard cr.ui.Grid (same as in the Files app thumbnail mode). - The new delete button does not really delete the files. - Standard (browser-provided) tooltips on the buttons look awful on Aura, need to change the black background. BUG=142542 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=153488

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 24

Patch Set 3 : Addressed comments #

Patch Set 4 : Small fix #

Total comments: 3

Patch Set 5 : Addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+949 lines, -324 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/css/gallery.css View 7 chunks +120 lines, -28 lines 0 comments Download
M chrome/browser/resources/file_manager/gallery.html View 1 2 chunks +18 lines, -5 lines 0 comments Download
A chrome/browser/resources/file_manager/images/gallery/icon_1up.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/file_manager/images/gallery/icon_1up_selected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/file_manager/images/gallery/icon_delete.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/file_manager/images/gallery/icon_delete_selected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/file_manager/images/gallery/icon_edit.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/file_manager/images/gallery/icon_edit_selected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/file_manager/images/gallery/icon_mosaic.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/file_manager/images/gallery/icon_mosaic_selected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/file_manager/images/gallery/icon_share.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/file_manager/images/gallery/icon_share_selected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/file_manager/images/gallery/icon_slideshow.png View 0 chunks +-1 lines, --1 lines 0 comments Download
A chrome/browser/resources/file_manager/images/gallery/icon_slideshow_selected.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/browser/resources/file_manager/js/image_editor/image_view.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/gallery.js View 1 2 3 17 chunks +285 lines, -112 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/gallery_scripts.js View 1 chunk +13 lines, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/photo/ribbon.js View 1 2 3 4 9 chunks +163 lines, -54 lines 0 comments Download
M chrome/browser/resources/file_manager/js/photo/slide_mode.js View 1 2 3 4 18 chunks +324 lines, -136 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Vladislav Kaznacheev
Please review
8 years, 4 months ago (2012-08-20 13:57:30 UTC) #1
dgozman
https://chromiumcodereview.appspot.com/10829421/diff/10034/chrome/browser/resources/file_manager/js/photo/gallery.js File chrome/browser/resources/file_manager/js/photo/gallery.js (right): https://chromiumcodereview.appspot.com/10829421/diff/10034/chrome/browser/resources/file_manager/js/photo/gallery.js#newcode377 chrome/browser/resources/file_manager/js/photo/gallery.js:377: return this.dataModel_.item(index); You can use this.dataModel_.item.bind(this.dataModel_) https://chromiumcodereview.appspot.com/10829421/diff/10034/chrome/browser/resources/file_manager/js/photo/gallery.js#newcode427 chrome/browser/resources/file_manager/js/photo/gallery.js:427: if ...
8 years, 3 months ago (2012-08-27 13:23:41 UTC) #2
Vladislav Kaznacheev
PTAL https://chromiumcodereview.appspot.com/10829421/diff/10034/chrome/browser/resources/file_manager/js/photo/gallery.js File chrome/browser/resources/file_manager/js/photo/gallery.js (right): https://chromiumcodereview.appspot.com/10829421/diff/10034/chrome/browser/resources/file_manager/js/photo/gallery.js#newcode377 chrome/browser/resources/file_manager/js/photo/gallery.js:377: return this.dataModel_.item(index); On 2012/08/27 13:23:42, dgozman wrote: > ...
8 years, 3 months ago (2012-08-27 14:49:08 UTC) #3
dgozman
LGTM https://chromiumcodereview.appspot.com/10829421/diff/15004/chrome/browser/resources/file_manager/js/photo/ribbon.js File chrome/browser/resources/file_manager/js/photo/ribbon.js (right): https://chromiumcodereview.appspot.com/10829421/diff/15004/chrome/browser/resources/file_manager/js/photo/ribbon.js#newcode98 chrome/browser/resources/file_manager/js/photo/ribbon.js:98: var persistentNodes = this.querySelectorAll('ribbon-image:not([vanishing])'); ribbon-image is a class, ...
8 years, 3 months ago (2012-08-27 15:07:42 UTC) #4
Vladislav Kaznacheev
8 years, 3 months ago (2012-08-30 09:58:45 UTC) #5
http://codereview.chromium.org/10829421/diff/15004/chrome/browser/resources/f...
File chrome/browser/resources/file_manager/js/photo/ribbon.js (right):

http://codereview.chromium.org/10829421/diff/15004/chrome/browser/resources/f...
chrome/browser/resources/file_manager/js/photo/ribbon.js:98: var persistentNodes
= this.querySelectorAll('ribbon-image:not([vanishing])');
On 2012/08/27 15:07:43, dgozman wrote:
> ribbon-image is a class, right? Forgot the dot.

Done.

Powered by Google App Engine
This is Rietveld 408576698