Add MouseClampingFilter and update ClientSession to use it.

Add MouseClampingFilter and update ClientSession to use it.

This removes the need for ClientSession to implement InputStub.

BUG=118511
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152501

[Wez, 2012-08-20 17:25:36]

I'm not terrifically happy with this implementation; I'd like to get to a point
where changes in the dimensions of the host are notified via callback, in which
case ClientSession can reconfigure the MouseInputFilter's output size.

[simonmorris, 2012-08-20 19:46:56]

On 2012/08/20 17:25:36, Wez wrote:
> I'm not terrifically happy with this implementation; I'd like to get to a
point
> where changes in the dimensions of the host are notified via callback, in
which
> case ClientSession can reconfigure the MouseInputFilter's output size.

Sounds good, but this CL doesn't make things worse in any dimension, and makes
them better in at least one.

[simonmorris, 2012-08-20 19:47:03]

http://codereview.chromium.org/10829409/diff/1/remoting/host/mouse_clamping_f...
File remoting/host/mouse_clamping_filter.h (right):

http://codereview.chromium.org/10829409/diff/1/remoting/host/mouse_clamping_f...
remoting/host/mouse_clamping_filter.h:18: class MouseClampingFilter : public
protocol::MouseInputFilter {
Implementation inheritance is brittle. It'd be better to delegate to a
MouseInputFilter member.

[Wez, 2012-08-20 20:26:25]

http://codereview.chromium.org/10829409/diff/1/remoting/host/mouse_clamping_f...
File remoting/host/mouse_clamping_filter.h (right):

http://codereview.chromium.org/10829409/diff/1/remoting/host/mouse_clamping_f...
remoting/host/mouse_clamping_filter.h:18: class MouseClampingFilter : public
protocol::MouseInputFilter {
On 2012/08/20 19:47:04, simonmorris wrote:
> Implementation inheritance is brittle. It'd be better to delegate to a
> MouseInputFilter member.

I agree in principle but this is such a trivial implementation that delegation
added more boilerplate than I felt was worth it.

I've re-expressed this as an InputFilter that accepts the MouseInputFilter to
configure as a ctor parameter, and sets it as the target InputStub.

[simonmorris, 2012-08-20 20:59:44]

http://codereview.chromium.org/10829409/diff/6001/remoting/host/mouse_clampin...
File remoting/host/mouse_clamping_filter.cc (right):

http://codereview.chromium.org/10829409/diff/6001/remoting/host/mouse_clampin...
remoting/host/mouse_clamping_filter.cc:18:
mouse_input_filter_(mouse_input_filter) {
Aliasing an object as both a member variable and as an instance of a base class
is unexpected, and a little confusing.

I preferred the version that just had implementation inheritance. I'll lgtm it
if you still prefer it to delegation. But could you merge it with
http://codereview.chromium.org/10860033/ first? I think that one and this one
conflict.

[commit-bot: I haz the power, 2012-08-20 23:45:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wez@chromium.org/10829409/10001

[commit-bot: I haz the power, 2012-08-21 04:35:08]

Change committed as 152501