debugd: Add TestICMP functionality.

debugd: Add TestICMP functionality.

BUG=139442
TEST=CQ

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152168

[hshi1, 2012-08-17 21:07:37]

Please take a look, this wires up the debugd's TestICMP interface that Elly
recently added.

[satorux1, 2012-08-17 21:13:16]

http://codereview.chromium.org/10829396/diff/1/chromeos/dbus/debug_daemon_cli...
File chromeos/dbus/debug_daemon_client.h (right):

http://codereview.chromium.org/10829396/diff/1/chromeos/dbus/debug_daemon_cli...
chromeos/dbus/debug_daemon_client.h:108: // or IPv6 address.
could you add some examples? can this be a host name like www.google.com?

http://codereview.chromium.org/10829396/diff/1/chromeos/dbus/debug_daemon_cli...
chromeos/dbus/debug_daemon_client.h:110: const std::string& host,
if this only accepts IP address, host -> ip_address

nit: move this to the previous line?

http://codereview.chromium.org/10829396/diff/1/chromeos/dbus/mock_debug_daemo...
File chromeos/dbus/mock_debug_daemon_client.h (right):

http://codereview.chromium.org/10829396/diff/1/chromeos/dbus/mock_debug_daemo...
chromeos/dbus/mock_debug_daemon_client.h:31: const TestICMPCallback&));
move this to the last line?

[hshi1, 2012-08-17 21:22:59]

http://codereview.chromium.org/10829396/diff/1/chromeos/dbus/debug_daemon_cli...
File chromeos/dbus/debug_daemon_client.h (right):

http://codereview.chromium.org/10829396/diff/1/chromeos/dbus/debug_daemon_cli...
chromeos/dbus/debug_daemon_client.h:108: // or IPv6 address.
On 2012/08/17 21:13:16, satorux1 wrote:
> could you add some examples? can this be a host name like
http://www.google.com?

No this must be numeric IP address. Done.

http://codereview.chromium.org/10829396/diff/1/chromeos/dbus/debug_daemon_cli...
chromeos/dbus/debug_daemon_client.h:110: const std::string& host,
On 2012/08/17 21:13:16, satorux1 wrote:
> if this only accepts IP address, host -> ip_address
> 
> nit: move this to the previous line? 

Done.

http://codereview.chromium.org/10829396/diff/1/chromeos/dbus/mock_debug_daemo...
File chromeos/dbus/mock_debug_daemon_client.h (right):

http://codereview.chromium.org/10829396/diff/1/chromeos/dbus/mock_debug_daemo...
chromeos/dbus/mock_debug_daemon_client.h:31: const TestICMPCallback&));
On 2012/08/17 21:13:16, satorux1 wrote:
> move this to the last line?

Done.

[satorux1, 2012-08-17 21:28:58]

LGTM

[commit-bot: I haz the power, 2012-08-17 21:32:57]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/hshi@chromium.org/10829396/7002