Fix tab-strip related constants to accommodate the new images.

Fix tab-strip related constants to accommodate the new images.
1. Shift tab contents up by 2px.
2. Shift close button left by 4px.
3. Increase the space between tabs (the width of the "V") by 3px.
4. Shift omnibox down 1px.

BUG=137351
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152429

[sky, 2012-08-20 15:08:04]

LGTM

[sky, 2012-08-20 15:08:54]

Make sure you turn on stacked tabs to see if those constants need to
be tweaked too. You can do it with --enable-stacked-tab-strip .

  -Scott

On Fri, Aug 17, 2012 at 11:56 AM,  <varunjain@chromium.org> wrote:
> Reviewers: sky,
>
> Description:
> Fix tab-strip related constants to accommodate the new images.
> 1. Shift tab contents up by 2px.
> 2. Shift close button left by 4px.
> 3. Increase the space between tabs (the width of the "V") by 3px.
>
> BUG=137351
> TEST=none
>
>
> Please review this at https://chromiumcodereview.appspot.com/10829389/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files:
>   M chrome/browser/ui/views/tabs/tab.cc
>   M chrome/browser/ui/views/tabs/tab_strip.cc
>
>
> Index: chrome/browser/ui/views/tabs/tab.cc
> diff --git a/chrome/browser/ui/views/tabs/tab.cc
> b/chrome/browser/ui/views/tabs/tab.cc
> index
>
0afd77e3fc2aaae73cb406d049ef4118ee5b8129..873846e414bf2b992af4c627f0e7d6a7d865e861
> 100644
> --- a/chrome/browser/ui/views/tabs/tab.cc
> +++ b/chrome/browser/ui/views/tabs/tab.cc
> @@ -57,7 +57,7 @@ int top_padding() {
>      switch (ui::GetDisplayLayout()) {
>        case ui::LAYOUT_ASH:
>        case ui::LAYOUT_DESKTOP:
> -        value = 8;
> +        value = 6;
>          break;
>        case ui::LAYOUT_TOUCH:
>          value = 12;
> @@ -166,7 +166,7 @@ static const int kCloseButtonVertFuzz = 1;
>  static const int kCloseButtonVertFuzz = 0;
>  #endif
>  // Additional horizontal offset for close button relative to title text.
> -static const int kCloseButtonHorzFuzz = 7;
> +static const int kCloseButtonHorzFuzz = 3;
>
>  // When a non-mini-tab becomes a mini-tab the width of the tab animates. If
>  // the width of a mini-tab is >= kMiniTabRendererAsNormalTabWidth then the
> tab
> Index: chrome/browser/ui/views/tabs/tab_strip.cc
> diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc
> b/chrome/browser/ui/views/tabs/tab_strip.cc
> index
>
f2f084a63618706cb2f9ac32ebd377ed4b931f00..88af36e420efaeb4f56039c504f0f5ba1134eff7
> 100644
> --- a/chrome/browser/ui/views/tabs/tab_strip.cc
> +++ b/chrome/browser/ui/views/tabs/tab_strip.cc
> @@ -146,7 +146,7 @@ int tab_h_offset() {
>      switch (ui::GetDisplayLayout()) {
>        case ui::LAYOUT_ASH:
>        case ui::LAYOUT_DESKTOP:
> -        value = -29;
> +        value = -26;
>          break;
>        case ui::LAYOUT_TOUCH:
>          value = -39;
>
>

[varunjain, 2012-08-20 15:52:39]

On 2012/08/20 15:08:54, sky wrote:
> Make sure you turn on stacked tabs to see if those constants need to
> be tweaked too. You can do it with --enable-stacked-tab-strip .

seems to look alright. Thanks.

> 
>   -Scott
> 
> On Fri, Aug 17, 2012 at 11:56 AM,  <mailto:varunjain@chromium.org> wrote:
> > Reviewers: sky,
> >
> > Description:
> > Fix tab-strip related constants to accommodate the new images.
> > 1. Shift tab contents up by 2px.
> > 2. Shift close button left by 4px.
> > 3. Increase the space between tabs (the width of the "V") by 3px.
> >
> > BUG=137351
> > TEST=none
> >
> >
> > Please review this at https://chromiumcodereview.appspot.com/10829389/
> >
> > SVN Base: svn://svn.chromium.org/chrome/trunk/src
> >
> > Affected files:
> >   M chrome/browser/ui/views/tabs/tab.cc
> >   M chrome/browser/ui/views/tabs/tab_strip.cc
> >
> >
> > Index: chrome/browser/ui/views/tabs/tab.cc
> > diff --git a/chrome/browser/ui/views/tabs/tab.cc
> > b/chrome/browser/ui/views/tabs/tab.cc
> > index
> >
>
0afd77e3fc2aaae73cb406d049ef4118ee5b8129..873846e414bf2b992af4c627f0e7d6a7d865e861
> > 100644
> > --- a/chrome/browser/ui/views/tabs/tab.cc
> > +++ b/chrome/browser/ui/views/tabs/tab.cc
> > @@ -57,7 +57,7 @@ int top_padding() {
> >      switch (ui::GetDisplayLayout()) {
> >        case ui::LAYOUT_ASH:
> >        case ui::LAYOUT_DESKTOP:
> > -        value = 8;
> > +        value = 6;
> >          break;
> >        case ui::LAYOUT_TOUCH:
> >          value = 12;
> > @@ -166,7 +166,7 @@ static const int kCloseButtonVertFuzz = 1;
> >  static const int kCloseButtonVertFuzz = 0;
> >  #endif
> >  // Additional horizontal offset for close button relative to title text.
> > -static const int kCloseButtonHorzFuzz = 7;
> > +static const int kCloseButtonHorzFuzz = 3;
> >
> >  // When a non-mini-tab becomes a mini-tab the width of the tab animates. If
> >  // the width of a mini-tab is >= kMiniTabRendererAsNormalTabWidth then the
> > tab
> > Index: chrome/browser/ui/views/tabs/tab_strip.cc
> > diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc
> > b/chrome/browser/ui/views/tabs/tab_strip.cc
> > index
> >
>
f2f084a63618706cb2f9ac32ebd377ed4b931f00..88af36e420efaeb4f56039c504f0f5ba1134eff7
> > 100644
> > --- a/chrome/browser/ui/views/tabs/tab_strip.cc
> > +++ b/chrome/browser/ui/views/tabs/tab_strip.cc
> > @@ -146,7 +146,7 @@ int tab_h_offset() {
> >      switch (ui::GetDisplayLayout()) {
> >        case ui::LAYOUT_ASH:
> >        case ui::LAYOUT_DESKTOP:
> > -        value = -29;
> > +        value = -26;
> >          break;
> >        case ui::LAYOUT_TOUCH:
> >          value = -39;
> >
> >

[commit-bot: I haz the power, 2012-08-20 15:52:46]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/10829389/3001

[commit-bot: I haz the power, 2012-08-20 20:15:03]

Try job failure for 10829389-3001 (retry) on linux_chromeos for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2012-08-20 20:17:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/varunjain@chromium.org/10829389/3001

[commit-bot: I haz the power, 2012-08-20 23:48:41]

Change committed as 152429