SystemMonitor: Pull device type into the device id

chrome/browser/media_gallery/media_file_system_registry.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // MediaFileSystemRegistry implementation.
 
 #include "chrome/browser/media_gallery/media_file_system_registry.h"
 
 #include <set>
 
 #include "base/file_path.h"
 #include "base/path_service.h"
 #include "base/system_monitor/system_monitor.h"
 #include "base/utf_string_conversions.h"
+#include "chrome/browser/media_gallery/media_storage_util.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/extension_constants.h"
 #include "chrome/common/extensions/extension.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_source.h"
 #include "content/public/browser/notification_types.h"
 #include "content/public/browser/render_process_host.h"
 #include "webkit/fileapi/file_system_types.h"
 #include "webkit/fileapi/isolated_context.h"
 #include "webkit/fileapi/media/media_file_system_config.h"
@@ skipping 10 matching lines @@
     g_media_file_system_registry = LAZY_INSTANCE_INITIALIZER;
 
 using base::SystemMonitor;
 using content::BrowserThread;
 using content::RenderProcessHost;
 using fileapi::IsolatedContext;
 
 namespace {
 
 bool IsGalleryPermittedForExtension(const extensions::Extension& extension,
-                                    SystemMonitor::MediaDeviceType type,
                                     const FilePath::StringType& location) {
   if (extension.HasAPIPermission(
         extensions::APIPermission::kMediaGalleriesAllGalleries)) {
     return true;
   }
   // TODO(vandebo) Check with prefs for permission to this gallery.
   return false;
 }
 
 }  // namespace
@@ skipping 18 matching lines @@
   std::pair<ChildIdToMediaFSMap::iterator, bool> ret =
       media_fs_map_.insert(std::make_pair(rph, MediaPathToFSIDMap()));
   ChildIdToMediaFSMap::iterator& child_it = ret.first;
   if (ret.second) {
     // Never seen a GetMediaFileSystems call from this RPH. Initialize its
     // file system mappings.
     RegisterForRPHGoneNotifications(rph);
     FilePath pictures_path;
     // TODO(vandebo) file system galleries need a unique id as well.
     if (PathService::Get(chrome::DIR_USER_PICTURES, &pictures_path) &&
-        IsGalleryPermittedForExtension(extension, SystemMonitor::TYPE_PATH,
-                                       pictures_path.value())) {
-      std::string fsid = RegisterPathAsFileSystem(SystemMonitor::TYPE_PATH,
-                                                  pictures_path);
+        IsGalleryPermittedForExtension(extension, pictures_path.value())) {
+      std::string fsid = RegisterPathAsFileSystem(pictures_path);
       child_it->second.insert(std::make_pair(pictures_path, fsid));
     }
   }
 
   // TODO(thestig) Handle overlap between devices and media directories.
   SystemMonitor* monitor = SystemMonitor::Get();
   const std::vector<SystemMonitor::MediaDeviceInfo> media_devices =
       monitor->GetAttachedMediaDevices();
   for (size_t i = 0; i < media_devices.size(); ++i) {
-    if (media_devices[i].type == SystemMonitor::TYPE_PATH &&
-        IsGalleryPermittedForExtension(extension, media_devices[i].type,
-                                       media_devices[i].location)) {
+    MediaStorageUtil::Type type;
+    MediaStorageUtil::CrackDeviceId(media_devices[i].unique_id, &type, NULL);
+    if (type != MediaStorageUtil::USB_MTP &&

[kmadhusu, 2012/08/20 17:13:50]

How about adding a TODO to handle MTP devices?

[vandebo (ex-Chrome), 2012/08/20 18:35:14]

Done.

+        IsGalleryPermittedForExtension(extension, media_devices[i].location)) {
       device_id_map_.insert(std::make_pair(media_devices[i].unique_id,
                                            media_devices[i]));
       FilePath path(media_devices[i].location);
-      const std::string fsid = RegisterPathAsFileSystem(media_devices[i].type,
-                                                        path);
+      const std::string fsid = RegisterPathAsFileSystem(path);
       child_it->second.insert(std::make_pair(path, fsid));
     }
   }
 
   MediaPathToFSIDMap& child_map = child_it->second;
   for (MediaPathToFSIDMap::const_iterator it = child_map.begin();
        it != child_map.end();
        ++it) {
     MediaFSInfo entry;
     // TODO(vandebo) use a better name, fsid for now.
     entry.name = it->second;
     entry.fsid = it->second;
     entry.path = it->first;
     results.push_back(entry);
   }
   return results;
 }
 
 void MediaFileSystemRegistry::OnMediaDeviceDetached(const std::string& id) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   DeviceIdToInfoMap::iterator it = device_id_map_.find(id);
   if (it == device_id_map_.end())
     return;
 
   FilePath path(it->second.location);
-  RevokeMediaFileSystem(it->second.type, path);
+  RevokeMediaFileSystem(path);
   device_id_map_.erase(it);
 }
 
 void MediaFileSystemRegistry::Observe(
     int type,
     const content::NotificationSource& source,
     const content::NotificationDetails& details) {
   DCHECK(type == content::NOTIFICATION_RENDERER_PROCESS_CLOSED ||
          type == content::NOTIFICATION_RENDERER_PROCESS_TERMINATED);
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
@@ skipping 41 matching lines @@
 
 void MediaFileSystemRegistry::UnregisterForRPHGoneNotifications(
     const content::RenderProcessHost* rph) {
   registrar_.Remove(this, content::NOTIFICATION_RENDERER_PROCESS_TERMINATED,
                     content::Source<RenderProcessHost>(rph));
   registrar_.Remove(this, content::NOTIFICATION_RENDERER_PROCESS_CLOSED,
                     content::Source<RenderProcessHost>(rph));
 }
 
 std::string MediaFileSystemRegistry::RegisterPathAsFileSystem(
-    const SystemMonitor::MediaDeviceType& device_type, const FilePath& path) {
+    const FilePath& path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   // Sanity checks for |path|.
   CHECK(path.IsAbsolute());
   CHECK(!path.ReferencesParent());
 
-  fileapi::FileSystemType type = fileapi::kFileSystemTypeUnknown;
-  switch (device_type) {
-    case SystemMonitor::TYPE_MTP:
-      type = fileapi::kFileSystemTypeDeviceMedia;
-      break;
-    case SystemMonitor::TYPE_PATH:
-      type = fileapi::kFileSystemTypeNativeMedia;
-      break;
-  }
-
   // The directory name is not exposed to the js layer and we simply use
   // a fixed name (as we only register a single directory per file system).
   std::string register_name(extension_misc::kMediaFileSystemPathPart);
   const std::string fsid =
       IsolatedContext::GetInstance()->RegisterFileSystemForPath(
-          type, path, &register_name);
+          fileapi::kFileSystemTypeNativeMedia, path, &register_name);
   CHECK(!fsid.empty());
   return fsid;
 }
 
-void MediaFileSystemRegistry::RevokeMediaFileSystem(
-    const SystemMonitor::MediaDeviceType& device_type, const FilePath& path) {
+void MediaFileSystemRegistry::RevokeMediaFileSystem(const FilePath& path) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
 
   IsolatedContext* isolated_context = IsolatedContext::GetInstance();
   isolated_context->RevokeFileSystemByPath(path);
 
   for (ChildIdToMediaFSMap::iterator child_it = media_fs_map_.begin();
        child_it != media_fs_map_.end();
        ++child_it) {
     MediaPathToFSIDMap& child_map = child_it->second;
     MediaPathToFSIDMap::iterator media_path_it = child_map.find(path);
     if (media_path_it == child_map.end())
       continue;
 
-    // TODO(kmadhusu, vandebo): Clean up this code. http://crbug.com/140340.
-
-    // Do the clean up tasks related to the file system.
-    switch (device_type) {
-      case SystemMonitor::TYPE_MTP:
-#if defined(SUPPORT_MEDIA_FILESYSTEM)
-        MediaDeviceMapService::GetInstance()->RemoveMediaDevice(path.value());
-#endif
-        break;
-      case SystemMonitor::TYPE_PATH:
-        break;
-    }
     child_map.erase(media_path_it);
   }
 }
 
 }  // namespace chrome