Remove call to UserManager::Get when initializing UserManager

Remove call to UserManager::Get when initializing UserManager


This CL removes UserManager::Get()(for ephemeral user check) out from 
WallpaperManager::SaveUserWallpaperProperties(called when initializing UserManager).
It was creating a deadlock and make chrome hang on startup screen.

The ephemeral user check in SaveUserWallpaperProperties is not correct either.
We should not check if current logged in user is ephemeral user while we try
to save wallpaper properties for some other user specified by email.

BUG=142440
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152136

[bshe, 2012-08-17 15:48:39]

Hi Ivan.

Could you please take a look at this CL? Thanks!

[Dmitry Polukhin, 2012-08-17 16:32:50]

LGTM

[Ivan Korotkov, 2012-08-17 19:10:57]

lgtm

http://codereview.chromium.org/10829381/diff/8001/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/wallpaper_manager.h (right):

http://codereview.chromium.org/10829381/diff/8001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/wallpaper_manager.h:95: void
SaveUserWallpaperProperties(const std::string& email,
Let's rename it to Set... because Save... already implies persistence.

http://codereview.chromium.org/10829381/diff/8001/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/wallpaper_manager.h:191: // email of current
logged in user. We should not persist data for ephemeral
Please rephrase this to what the function actually serves for, i.e.: // Whether
wallpaper data should be persisted for user |email|.

[rkc, 2012-08-17 19:16:42]

+bartfab for FYI

On 2012/08/17 19:10:57, Ivan Korotkov wrote:
> lgtm
> 
>
http://codereview.chromium.org/10829381/diff/8001/chrome/browser/chromeos/log...
> File chrome/browser/chromeos/login/wallpaper_manager.h (right):
> 
>
http://codereview.chromium.org/10829381/diff/8001/chrome/browser/chromeos/log...
> chrome/browser/chromeos/login/wallpaper_manager.h:95: void
> SaveUserWallpaperProperties(const std::string& email,
> Let's rename it to Set... because Save... already implies persistence.
> 
>
http://codereview.chromium.org/10829381/diff/8001/chrome/browser/chromeos/log...
> chrome/browser/chromeos/login/wallpaper_manager.h:191: // email of current
> logged in user. We should not persist data for ephemeral
> Please rephrase this to what the function actually serves for, i.e.: //
Whether
> wallpaper data should be persisted for user |email|.

[bshe, 2012-08-17 19:21:36]

Done. will run try bots again and submit. Thanks

https://chromiumcodereview.appspot.com/10829381/diff/8001/chrome/browser/chro...
File chrome/browser/chromeos/login/wallpaper_manager.h (right):

https://chromiumcodereview.appspot.com/10829381/diff/8001/chrome/browser/chro...
chrome/browser/chromeos/login/wallpaper_manager.h:95: void
SaveUserWallpaperProperties(const std::string& email,
On 2012/08/17 19:10:57, Ivan Korotkov wrote:
> Let's rename it to Set... because Save... already implies persistence.

Done.

https://chromiumcodereview.appspot.com/10829381/diff/8001/chrome/browser/chro...
chrome/browser/chromeos/login/wallpaper_manager.h:191: // email of current
logged in user. We should not persist data for ephemeral
On 2012/08/17 19:10:57, Ivan Korotkov wrote:
> Please rephrase this to what the function actually serves for, i.e.: //
Whether
> wallpaper data should be persisted for user |email|.

Done.