Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 10829380: Detect NaCl osabi from objfile (Closed)

Created:
8 years, 4 months ago by eaeltsin
Modified:
8 years, 4 months ago
Reviewers:
halyavin
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/nacl-gdb.git@master
Visibility:
Public.

Description

Detect NaCl osabi from objfile This is needed to obtain correct gdbarch structure when doing get_objfile_arch. In particular, with correct gdbarch structure GDB calls correct gdbarch_skip_prologue hook when setting breakpoints on function start. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2898 Committed: https://git.chromium.org/gitweb?p=native_client/nacl-gdb.git;a=commit;h=b95b51f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M gdb/nacl-tdep.c View 3 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
eaeltsin
8 years, 4 months ago (2012-08-17 15:27:04 UTC) #1
halyavin
8 years, 4 months ago (2012-08-17 15:27:51 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698