Add erroneous elements for function types and use them to allow unresolvable constructors to be han…

lib/compiler/implementation/resolver.dart

Index: lib/compiler/implementation/resolver.dart
diff --git a/lib/compiler/implementation/resolver.dart b/lib/compiler/implementation/resolver.dart
index 132050d262edc7db89d26cdf70847d240fa79aab..50a89c3bfd76a20f0386d2034de4fa931d413939 100644
--- a/lib/compiler/implementation/resolver.dart
+++ b/lib/compiler/implementation/resolver.dart
@@ -1418,18 +1418,17 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
 
   visitNewExpression(NewExpression node) {
     Node selector = node.send.selector;
-
     FunctionElement constructor = resolveConstructor(node);
     resolveSelector(node.send);
     resolveArguments(node.send.argumentsNode);
-    if (constructor === null) return null;
+    useElement(node.send, constructor);
+    if (Element.isInvalid(constructor)) return constructor;
     // TODO(karlklose): handle optional arguments.
     if (node.send.argumentCount() != constructor.parameterCount(compiler)) {
       // TODO(ngeoffray): resolution error with wrong number of
       // parameters. We cannot do this rigth now because of the
       // List constructor.
     }
-    useElement(node.send, constructor);
     world.registerStaticUse(constructor);
     compiler.withCurrentElement(constructor, () {
       FunctionExpression tree = constructor.parseNode(compiler);
@@ -1460,6 +1459,12 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
     }
   }
 
+  /**
+   * Try to resolve the constructor that is referred to by this

[ahe, 2012/08/20 15:06:47]

"this" is not NewExpression, [node] is. So:

Try to resolve the constructor that is referred to by [node].

[karlklose, 2012/08/21 11:44:10]

Done.

+   * [NewExpression].
+   * Note: this function may return an ErroneousFunctionElement instead of
+   * [null], if there is no corresponding constructor, class or library.
+   */
   FunctionElement resolveConstructor(NewExpression node) {
     FunctionElement constructor =
         node.accept(new ConstructorResolver(compiler, this));
@@ -1470,9 +1475,6 @@ class ResolverVisitor extends CommonResolverVisitor<Element> {
       if (resolved !== null && resolved.kind === ElementKind.TYPE_VARIABLE) {
         error(node, MessageKind.TYPE_VARIABLE_AS_CONSTRUCTOR);
         return null;
-      } else {
-        error(node.send, MessageKind.CANNOT_FIND_CONSTRUCTOR, [node.send]);
-        return null;
       }
     }
     return constructor;
@@ -2248,22 +2250,43 @@ class SignatureResolver extends CommonResolverVisitor<Element> {
 
 class ConstructorResolver extends CommonResolverVisitor<Element> {
   final ResolverVisitor resolver;
+
   ConstructorResolver(Compiler compiler, this.resolver) : super(compiler);
 
   visitNode(Node node) {
     throw 'not supported';
   }
 
+  FunctionElement lookupConstructor(ClassElement cls,
+                                    Node diagnosticNode,
+                                    SourceString constructorName) {
+    cls.ensureResolved(compiler);
+    Element result = cls.lookupConstructor(cls.name, constructorName);
+    if (result === null) {
+      String fullConstructorName = cls.name.slowToString();
+      if (constructorName !== const SourceString('')) {
+        fullConstructorName = '$fullConstructorName'
+                              '.${constructorName.slowToString()}';
+      }
+      ResolutionWarning message  =
+          new ResolutionWarning(MessageKind.CANNOT_FIND_CONSTRUCTOR,
+                                [fullConstructorName]);
+      compiler.reportWarning(diagnosticNode, message);
+      return new ErroneousFunctionElement(message, cls);
+    }
+    return result;
+  }
+
   visitNewExpression(NewExpression node) {
     Node selector = node.send.selector;
     Element e = visit(selector);
-    if (e !== null && e.kind === ElementKind.CLASS) {
+    if (e !== null && e.isValid() && e.kind === ElementKind.CLASS) {

[ahe, 2012/08/20 15:06:47]

I don't like having to check for null and valid.

[karlklose, 2012/08/21 11:44:10]

Done, forgot to change that after introducing the static helper method on
Element.

       ClassElement cls = e;
       cls.ensureResolved(compiler);
       if (cls.isInterface() && (cls.defaultClass === null)) {
         error(selector, MessageKind.CANNOT_INSTANTIATE_INTERFACE, [cls.name]);
       }
-      e = cls.lookupConstructor(cls.name);
+      e = lookupConstructor(cls, selector, const SourceString(''));
     }
     return e;
   }
@@ -2287,13 +2310,7 @@ class ConstructorResolver extends CommonResolverVisitor<Element> {
         error(node.receiver, MessageKind.CANNOT_INSTANTIATE_INTERFACE,
               [cls.name]);
       }
-      SourceString constructorName =
-        Elements.constructConstructorName(cls.name, name.source);
-      FunctionElement constructor = cls.lookupConstructor(constructorName);
-      if (constructor === null) {
-        error(name, MessageKind.CANNOT_FIND_CONSTRUCTOR, [name]);
-      }
-      e = constructor;
+      return lookupConstructor(cls, name, name.source);
     } else if (e.kind === ElementKind.PREFIX) {
       PrefixElement prefix = e;
       e = prefix.lookupLocalMember(name.source);