Add erroneous elements for function types and use them to allow unresolvable constructors to be han…

lib/compiler/implementation/typechecker.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 class TypeCheckerTask extends CompilerTask {
   TypeCheckerTask(Compiler compiler) : super(compiler);
   String get name() => "Type checker";
 
   static final bool LOG_FAILURES = false;
 
@@ skipping 317 matching lines @@
   Type visitFunctionDeclaration(FunctionDeclaration node) {
     analyze(node.function);
     return StatementType.NOT_RETURNING;
   }
 
   Type visitFunctionExpression(FunctionExpression node) {
     Type type;
     Type returnType;
     Type previousType;
     final FunctionElement element = elements[node];
+    if (Element.isInvalid(element)) return types.dynamicType;
     if (element.kind === ElementKind.GENERATIVE_CONSTRUCTOR ||
         element.kind === ElementKind.GENERATIVE_CONSTRUCTOR_BODY) {
       type = types.dynamicType;
       returnType = types.voidType;
     } else {
       FunctionType functionType = computeType(element);
       returnType = functionType.returnType;
       type = functionType;
     }
     Type previous = expectedReturnType;
@@ skipping 292 matching lines @@
     }
     return StatementType.RETURNING;
   }
 
   Type visitThrow(Throw node) {
     if (node.expression !== null) analyze(node.expression);
     return StatementType.RETURNING;
   }
 
   Type computeType(Element element) {
-    if (element === null) return types.dynamicType;
+    if (Element.isInvalid(element)) return types.dynamicType;
     Type result = element.computeType(compiler);
     return (result !== null) ? result : types.dynamicType;
   }
 
   Type visitTypeAnnotation(TypeAnnotation node) {
     return elements.getType(node);
   }
 
   visitTypeVariable(TypeVariable node) {
     return types.dynamicType;
@@ skipping 120 matching lines @@
   }
 
   visitCatchBlock(CatchBlock node) {
     return unhandledStatement();
   }
 
   visitTypedef(Typedef node) {
     return unhandledStatement();
   }
 }