Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 10829370: Make search icon in omnibox results hidpi (Closed)

Created:
8 years, 4 months ago by pkotwicz
Modified:
8 years, 4 months ago
Reviewers:
sky
CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, sadrul, ben+watch_chromium.org, tfarina, Aaron Boodman, James Su
Visibility:
Public.

Description

Make search icon in omnibox results hidpi Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=152379

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -76 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +4 lines, -4 lines 2 comments Download
M chrome/browser/ui/ash/app_list/search_builder.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_popup_view_mac.mm View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/autofill/autofill_popup_view_gtk.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.h View 2 chunks +3 lines, -8 lines 0 comments Download
M chrome/browser/ui/gtk/omnibox/omnibox_popup_view_gtk.cc View 4 chunks +6 lines, -15 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_popup_model.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/ui/omnibox/omnibox_popup_model.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/inline_omnibox_popup_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view_model.h View 2 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pkotwicz
This CL makes the search icon in the omnibox results appear in HiDPI. Not a ...
8 years, 4 months ago (2012-08-17 16:17:50 UTC) #1
pkotwicz
8 years, 4 months ago (2012-08-17 20:06:01 UTC) #2
sky
LGTM http://codereview.chromium.org/10829370/diff/2002/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): http://codereview.chromium.org/10829370/diff/2002/chrome/browser/extensions/extension_service.cc#newcode2260 chrome/browser/extensions/extension_service.cc:2260: return gfx::Image(omnibox_icon_manager_.GetIcon(extension_id)); Can GetIcon return a gfx::Image?
8 years, 4 months ago (2012-08-20 15:15:51 UTC) #3
pkotwicz
http://codereview.chromium.org/10829370/diff/2002/chrome/browser/extensions/extension_service.cc File chrome/browser/extensions/extension_service.cc (right): http://codereview.chromium.org/10829370/diff/2002/chrome/browser/extensions/extension_service.cc#newcode2260 chrome/browser/extensions/extension_service.cc:2260: return gfx::Image(omnibox_icon_manager_.GetIcon(extension_id)); That's a good idea. However doing this ...
8 years, 4 months ago (2012-08-20 15:52:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10829370/2002
8 years, 4 months ago (2012-08-20 16:03:25 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-20 20:28:02 UTC) #6
Change committed as 152379

Powered by Google App Engine
This is Rietveld 408576698