Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3571)

Unified Diff: chrome/test/functional/chromeos_login.py

Issue 10829367: [chromeos] Make testProfilePreservedBetweenLogins test robust (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/chromeos_login.py
diff --git a/chrome/test/functional/chromeos_login.py b/chrome/test/functional/chromeos_login.py
index db4995184094e5bacc9e09f266601a97d4221173..cfe0dbfe9f5dcfb938bc498431cf2f810be116d4 100755
--- a/chrome/test/functional/chromeos_login.py
+++ b/chrome/test/functional/chromeos_login.py
@@ -206,7 +206,12 @@ class ChromeosLogin(pyauto.PyUITest):
# Build up some history and setup state in "Local State".
url = self.GetHttpURLForDataPath('title2.html')
- self.NavigateToURL(url)
+ def _NavigateAndRecord():
+ self.NavigateToURL(url)
craigdh 2012/08/17 00:29:49 Do you need to navigate every time you try this? O
Nirnimesh 2012/08/17 00:39:19 Done.
+ return len(self.GetHistoryInfo().History())
+ # chromeos often takes a while to register URLs into history.
+ self.assertTrue(self.WaitUntil(_NavigateAndRecord),
+ msg='Could not open %s successfully' % url)
open('/home/chronos/__magic__', 'w').close()
open('/home/chronos/user/__magic__', 'w').close()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698