lib/dom/scripts/systemnative.py - Issue 10829357: Autogenerate typed array toDart methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/dom/scripts/systemnative.py

Issue 10829357: Autogenerate typed array toDart methods. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/dom/scripts/systemnative.py

diff --git a/lib/dom/scripts/systemnative.py b/lib/dom/scripts/systemnative.py

index df28efcba4c71677a4ee44ef808e46bb8be883bd..fee48c11f700a527c6164b548f863377eb18dcd5 100644

--- a/lib/dom/scripts/systemnative.py

+++ b/lib/dom/scripts/systemnative.py

@@ -367,10 +367,13 @@ class NativeImplementationGenerator(systembase.BaseGenerator):

INTERFACE=self._interface.id)

to_dart_emitter = emitter.Emitter()

- if ('CustomToJS' in self._interface.ext_attrs or

- 'CustomToJSObject' in self._interface.ext_attrs or

- 'PureInterface' in self._interface.ext_attrs or

- 'CPPPureInterface' in self._interface.ext_attrs or

+ ext_attrs = self._interface.ext_attrs

+ if ('CustomToJS' in ext_attrs or

+ ('CustomToJSObject' in ext_attrs and 'TypedArray' not in ext_attrs) or

+ 'PureInterface' in ext_attrs or

+ 'CPPPureInterface' in ext_attrs or

self._interface_type_info.custom_to_dart()):

to_dart_emitter.Emit(

' static Dart_Handle toDart(NativeType* value);\n')

« no previous file with comments | « no previous file | no next file » | no next file with comments »