Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Issue 10829355: Make checking the existence of the license file optional in the license tool (Closed)

Created:
8 years, 4 months ago by Steve Block
Modified:
8 years, 4 months ago
Reviewers:
Nico
CC:
chromium-reviews, pam+watch_chromium.org
Visibility:
Public.

Description

Make checking the existence of the license file optional in the license tool This is useful in situations where a checkout excludes some DEPS directories. In this case, a checkout may include the README.chromium file for a particular third-party project, but not the license file to which it refers. This change adds a new require_license_file argument to licenses.ParseDir(), with a default value of true. When true, there is no change in behaviour and if the license file is missing, an exception is raised. When false, if the license file is missing, we simply set the value of the 'License File' field of the returned metadata to None. This change also makes use of the new feature in webview_licenses.GetIncompatibleDirectories() and webview_licenses.GenerateNoticeFile(). BUG=138921 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=152091

Patch Set 1 #

Patch Set 2 : Remove unused print_warnings #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M android_webview/tools/webview_licenses.py View 1 4 chunks +7 lines, -7 lines 0 comments Download
M tools/licenses.py View 2 chunks +3 lines, -3 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Steve Block
8 years, 4 months ago (2012-08-16 15:22:48 UTC) #1
Nico
http://codereview.chromium.org/10829355/diff/2001/tools/licenses.py File tools/licenses.py (right): http://codereview.chromium.org/10829355/diff/2001/tools/licenses.py#newcode404 tools/licenses.py:404: 'license': open(metadata['License File'], 'rb').read(), Won't this be confused about ...
8 years, 4 months ago (2012-08-16 18:10:15 UTC) #2
Steve Block
http://codereview.chromium.org/10829355/diff/2001/tools/licenses.py File tools/licenses.py (right): http://codereview.chromium.org/10829355/diff/2001/tools/licenses.py#newcode404 tools/licenses.py:404: 'license': open(metadata['License File'], 'rb').read(), No, because metadata comes from ...
8 years, 4 months ago (2012-08-17 10:33:23 UTC) #3
Nico
8 years, 4 months ago (2012-08-17 16:15:30 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698