Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/harfbuzz/harfbuzz.gyp

Issue 10829354: Disable warnings in harfbuzz/ for Android when not using clang. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Disable it for cpp files too Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/harfbuzz/harfbuzz.gyp
diff --git a/third_party/harfbuzz/harfbuzz.gyp b/third_party/harfbuzz/harfbuzz.gyp
index bb7be865a276d70269095b1c2194cf1e67c852a9..76bd8009de909729e1fe634ce449a135caf07760 100644
--- a/third_party/harfbuzz/harfbuzz.gyp
+++ b/third_party/harfbuzz/harfbuzz.gyp
@@ -60,6 +60,18 @@
'../../build/linux/system.gyp:freetype2',
],
}],
+ ['OS == "android" and clang == 0', {
+ # The Android NDK compilers in the GCC 4.2 and 4.6 toolchains will
+ # show a warning about incompatible pointer signedness, but this
+ # warning cannot be disabled through an individual flag. To stop
+ # showing it, disable all warnings. Coverage is provided through
+ # clang builders, as well as Linux non-clang builders.
+ # TODO(beverloo): Re-enable warnings once the toolchains provide a
+ # way of disabling the specific warning.
+ 'cflags': [
+ '-w',
+ ],
+ }],
['clang == 1', {
'xcode_settings': {
'WARNING_CFLAGS': [
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698