Extensions Docs Server: Large performance increase

chrome/common/extensions/docs/server2/template_data_source.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 
 from docs_server_utils import FormatKey
 from file_system import FileNotFoundError
+import file_system_cache as fs_cache
 from third_party.handlebar import Handlebar
 
 EXTENSIONS_URL = '/chrome/extensions'
 
 def _MakeChannelDict(channel_name):
   return {
     'showWarning': channel_name != 'stable',
     'channels': [
       { 'name': 'Stable', 'path': 'stable' },
       { 'name': 'Dev',    'path': 'dev' },
@@ skipping 15 matching lines @@
   a Factory to cheaply construct these.
   """
 
   class Factory(object):
     """A factory to create lightweight TemplateDataSource instances bound to
     individual Requests.
     """
     def __init__(self,
                  channel_name,
                  api_data_source_factory,
-                 api_list_data_source,
-                 intro_data_source,
+                 api_list_data_source_factory,
+                 intro_data_source_factory,
                  samples_data_source_factory,
                  cache_builder,
                  public_template_path,
                  private_template_path):
       self._branch_info = _MakeChannelDict(channel_name)
       self._api_data_source_factory = api_data_source_factory
-      self._api_list_data_source = api_list_data_source
-      self._intro_data_source = intro_data_source
+      self._api_list_data_source_factory = api_list_data_source_factory
+      self._intro_data_source_factory = intro_data_source_factory
       self._samples_data_source_factory = samples_data_source_factory
-      self._cache = cache_builder.build(Handlebar)
+      self._cache = cache_builder.build(Handlebar, fs_cache.HANDLEBAR)
       self._public_template_path = public_template_path
       self._private_template_path = private_template_path
       self._static_resources = (
           (('/' + channel_name) if channel_name != 'local' else '') + '/static')
 
     def Create(self, request):
       """Returns a new TemplateDataSource bound to |request|.
       """
       return TemplateDataSource(
           self._branch_info,
           self._api_data_source_factory.Create(request),
-          self._api_list_data_source,
-          self._intro_data_source,
+          self._api_list_data_source_factory.Create(),
+          self._intro_data_source_factory.Create(),
           self._samples_data_source_factory.Create(request),
           self._cache,
           self._public_template_path,
           self._private_template_path,
           self._static_resources,
           request)
 
   def __init__(self,
                branch_info,
                api_data_source,
@@ skipping 45 matching lines @@
   def get(self, key):
     return self.GetTemplate(self._private_template_path, key)
 
   def GetTemplate(self, base_path, template_name):
     real_path = FormatKey(template_name)
     try:
       return self._cache.GetFromFile(base_path + '/' + real_path)
     except FileNotFoundError as e:
       logging.error(e)
       return None