Extensions Docs Server: Large performance increase

chrome/common/extensions/docs/server2/object_store.py

+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# Default to a 5 minute cache timeout.
+CACHE_TIMEOUT = 300
+
+BRANCH_UTILITY            = 'BranchUtility'
+FILE_SYSTEM_CACHE         = 'FileSystemCache'
+FILE_SYSTEM_CACHE_LISTING = 'FileSystemCacheListing'
+FILE_SYSTEM_READ          = 'Read'
+FILE_SYSTEM_STAT          = 'Stat'
+GITHUB_STAT               = 'GithubStat'
+
+class ObjectStore(object):
+  def Set(self, key, value, namespace, time=CACHE_TIMEOUT):
+    raise NotImplementedError()
+
+  def SetMulti(self, mapping, namespace, time=CACHE_TIMEOUT):
+    raise NotImplementedError()
+
+  def Get(self, key, namespace, time=CACHE_TIMEOUT):

[not at google - send to devlin, 2012/08/21 00:30:11]

I think these all need a bit of documentation, particularly since by looking at
the implementations Get() returns the value whereas GetMulti returns a Future.
Is that a correct observation?

I actually think that Get/GetMulti should both return Futures to be consistent,
though...

[cduvall, 2012/08/21 01:33:33]

Done.

+    raise NotImplementedError()
+
+  def GetMulti(self, keys, namespace, time=CACHE_TIMEOUT):
+    raise NotImplementedError()
+
+  def Delete(self, key, namespace):
+    raise NotImplementedError()