Extensions Docs Server: Large performance increase

chrome/common/extensions/docs/server2/memcache_object_store.py

+# Copyright (c) 2012 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+from appengine_wrappers import memcache
+from object_store import ObjectStore, CACHE_TIMEOUT
+
+class _AsyncMemcacheGetFuture(object):
+  def __init__(self, rpc):
+    self._rpc = rpc
+
+  def Get(self):
+    return self._rpc.get_result()
+
+class MemcacheObjectStore(ObjectStore):
+  def Set(self, key, value, namespace, time=CACHE_TIMEOUT):
+    memcache.set(key, value, namespace=namespace, time=time)

[not at google - send to devlin, 2012/08/21 00:30:11]

yeah, I wonder if we should call set_multi_async here anyway (or rather,
SetMulti({key: value}, namespace, time=time))

[cduvall, 2012/08/21 01:33:33]

Done.

+
+  def SetMulti(self, mapping, namespace, time=CACHE_TIMEOUT):
+    client = memcache.Client()
+    client.set_multi_async(mapping, namespace=namespace, time=time)

[not at google - send to devlin, 2012/08/21 00:30:11]

nit: inline client? and below?

[cduvall, 2012/08/21 01:33:33]

Done.

+
+  def Get(self, key, namespace, time=CACHE_TIMEOUT):
+    return memcache.get(key, namespace=namespace)

[not at google - send to devlin, 2012/08/21 00:30:11]

I wonder if this should also return a future (i.e. call GetMulti with [key])

In that case you could have ObjectStore implement Get/Set as delegates to
GetMulti/SetMulti and not need to implement it in here nor in
InMemoryObjectStore. Just a thought.

[cduvall, 2012/08/21 01:33:33]

Done.

+
+  def GetMulti(self, keys, namespace, time=CACHE_TIMEOUT):
+    client = memcache.Client()
+    rpc = client.get_multi_async(keys, namespace=namespace)
+    return _AsyncMemcacheGetFuture(rpc)
+
+  def Delete(self, key, namespace):
+    memcache.delete(key, namespace=namespace)