Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 10829333: Android: start building libwebview on FYI waterfall. (Closed)

Created:
8 years, 4 months ago by Torne
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Android: start building libwebview on FYI waterfall. Move the libwebview target to android_experimental so it gets compiled and linked on the FYI waterfall (but not the main waterfall or trybots yet). This will help us see when it's been broken by other changes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151877

Patch Set 1 #

Total comments: 1

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/all_android.gyp View 1 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Torne
8 years, 4 months ago (2012-08-15 11:38:03 UTC) #1
Peter Beverloo
+ilevy The FYI Builder makes different targets from what we used to run on the ...
8 years, 4 months ago (2012-08-15 12:26:45 UTC) #2
Isaac (away)
The compile_experimental is supposed be on the fyi builder. I didn't add it initially because ...
8 years, 4 months ago (2012-08-15 17:21:47 UTC) #3
Torne
On 2012/08/15 17:21:47, Isaac wrote: > The compile_experimental is supposed be on the fyi builder. ...
8 years, 4 months ago (2012-08-16 09:58:36 UTC) #4
Peter Beverloo
8 years, 4 months ago (2012-08-16 10:12:07 UTC) #5
This will need a rebase, but LGTM after that. You'll need at least a rubberstamp
from a full committer as well.

Powered by Google App Engine
This is Rietveld 408576698