[Chromoting] Cleanup branding variables in Chromoting gyp file.

[Chromoting] Cleanup branding variables in Chromoting gyp file.

Also remote tabs that crept into the remoting.gyp file.

[alexeypa (please no reviews), 2012-08-14 23:50:51]

lgtm, with a few nits.

http://codereview.chromium.org/10829327/diff/2001/remoting/host/installer/mac...
File remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist
(right):

http://codereview.chromium.org/10829327/diff/2001/remoting/host/installer/mac...
remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist:5:
<key>CFBundleDevelopmentRegion</key>
nit: I think we prefer 2 character wide indent.

http://codereview.chromium.org/10829327/diff/2001/remoting/host/me2me_prefere...
File remoting/host/me2me_preference_pane-Info.plist (right):

http://codereview.chromium.org/10829327/diff/2001/remoting/host/me2me_prefere...
remoting/host/me2me_preference_pane-Info.plist:5:
<key>CFBundleDevelopmentRegion</key>
nit: I think we prefer 2 character wide indent.

http://codereview.chromium.org/10829327/diff/2001/remoting/host/me2me_prefere...
remoting/host/me2me_preference_pane-Info.plist:26:
<string>COPYRIGHT_INFO</string>
nit: tab -> space

http://codereview.chromium.org/10829327/diff/2001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10829327/diff/2001/remoting/remoting.gyp#newco...
remoting/remoting.gyp:427: # TODO(lambroslambrou): When these strings are
localized, use "\n"
nit: Is the comment about '&#x0a' still relevant?

[garykac, 2012-08-17 18:47:26]

http://codereview.chromium.org/10829327/diff/2001/remoting/host/installer/mac...
File remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist
(right):

http://codereview.chromium.org/10829327/diff/2001/remoting/host/installer/mac...
remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist:5:
<key>CFBundleDevelopmentRegion</key>
On 2012/08/14 23:50:51, alexeypa wrote:
> nit: I think we prefer 2 character wide indent.

The plist files were initially auto-generated and use tabs on each line to
indent. I can follow-up with a separate cl to remove the tabs from each line if
needed.

http://codereview.chromium.org/10829327/diff/2001/remoting/host/me2me_prefere...
File remoting/host/me2me_preference_pane-Info.plist (right):

http://codereview.chromium.org/10829327/diff/2001/remoting/host/me2me_prefere...
remoting/host/me2me_preference_pane-Info.plist:5:
<key>CFBundleDevelopmentRegion</key>
On 2012/08/14 23:50:51, alexeypa wrote:
> nit: I think we prefer 2 character wide indent.

Auto-generated tab.

http://codereview.chromium.org/10829327/diff/2001/remoting/host/me2me_prefere...
remoting/host/me2me_preference_pane-Info.plist:26:
<string>COPYRIGHT_INFO</string>
On 2012/08/14 23:50:51, alexeypa wrote:
> nit: tab -> space

Tabs are everywhere in this file (not just this one line).

http://codereview.chromium.org/10829327/diff/2001/remoting/remoting.gyp
File remoting/remoting.gyp (right):

http://codereview.chromium.org/10829327/diff/2001/remoting/remoting.gyp#newco...
remoting/remoting.gyp:427: # TODO(lambroslambrou): When these strings are
localized, use "\n"
On 2012/08/14 23:50:51, alexeypa wrote:
> nit: Is the comment about '&#x0a' still relevant?

Yes, and we sadly cannot include comments in the branding_Chrome/Chromium file
(which is where I would have liked this comment to be).

[commit-bot: I haz the power, 2012-08-17 18:55:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/10829327/2001

[commit-bot: I haz the power, 2012-08-18 00:48:04]

Failed to apply the patch.
Adding         remoting/branding_Chrome
Adding         remoting/branding_Chromium
Deleting       remoting/chromium_branding
Deleting       remoting/google_chrome_branding
Sending       
remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist
Sending        remoting/host/me2me_preference_pane-Info.plist
Sending        remoting/host/plugin/constants.h
Sending        remoting/host/remoting_me2me_host-Info.plist
Sending        remoting/remoting.gyp
Sending        remoting/version.rc.version
Transmitting file data ........svn: Commit failed (details follow):
svn: Can't read from connection: Connection reset by peer

[commit-bot: I haz the power, 2012-08-18 03:49:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/garykac@chromium.org/10829327/2001

[commit-bot: I haz the power, 2012-08-18 03:49:25]

Failed to apply patch for
remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist:
While running patch -p0 --forward --force;
patching file
remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist
Hunk #1 FAILED at 25.
1 out of 1 hunk FAILED -- saving rejects to file
remoting/host/installer/mac/uninstaller/remoting_uninstaller-Info.plist.rej

[garykac, 2012-08-31 22:30:16]

This issue was committed on 17 Aug 2012 as:
https://src.chromium.org/viewvc/chrome?view=rev&revision=152182