Add mux-stream transport support in session description

Add mux-stream transport support in session description

Also moved NameToValue() and ValueToName() from jingle_messages.cc to name_value_map.h . These functions simplify string<->enum mapping.

BUG=137135
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151629

[Wez, 2012-08-14 20:56:32]

LGTM w/ nits :)

http://codereview.chromium.org/10829324/diff/1/remoting/protocol/jingle_messa...
File remoting/protocol/jingle_messages.cc (right):

http://codereview.chromium.org/10829324/diff/1/remoting/protocol/jingle_messa...
remoting/protocol/jingle_messages.cc:298: if (reason_string == NULL)
nit: You test |!action_attr| earlier but |reason_string == NULL| here; be
consistent. :)

http://codereview.chromium.org/10829324/diff/1/remoting/protocol/name_value_m...
File remoting/protocol/name_value_map.h (right):

http://codereview.chromium.org/10829324/diff/1/remoting/protocol/name_value_m...
remoting/protocol/name_value_map.h:11: struct NameMapElement {
nit: If you make both |value| and |name| template typed then you can make this
an A<->B map helper, which could then be re-used for things like the
native<->USB keycode lookup code.

http://codereview.chromium.org/10829324/diff/1/remoting/protocol/name_value_m...
remoting/protocol/name_value_map.h:28: T* result) {
nit: Why not return const T* and have the caller check the result for NULL?

[Sergey Ulanov, 2012-08-14 21:21:36]

http://codereview.chromium.org/10829324/diff/1/remoting/protocol/jingle_messa...
File remoting/protocol/jingle_messages.cc (right):

http://codereview.chromium.org/10829324/diff/1/remoting/protocol/jingle_messa...
remoting/protocol/jingle_messages.cc:298: if (reason_string == NULL)
On 2012/08/14 20:56:32, Wez wrote:
> nit: You test |!action_attr| earlier but |reason_string == NULL| here; be
> consistent. :)

Done.

http://codereview.chromium.org/10829324/diff/1/remoting/protocol/name_value_m...
File remoting/protocol/name_value_map.h (right):

http://codereview.chromium.org/10829324/diff/1/remoting/protocol/name_value_m...
remoting/protocol/name_value_map.h:11: struct NameMapElement {
On 2012/08/14 20:56:32, Wez wrote:
> nit: If you make both |value| and |name| template typed then you can make this
> an A<->B map helper, which could then be re-used for things like the
> native<->USB keycode lookup code.

We need to store char* in the static array (to avoid static
initializers/finalizers), but compare it to the string, so it's not that easy to
make it more generic.

http://codereview.chromium.org/10829324/diff/1/remoting/protocol/name_value_m...
remoting/protocol/name_value_map.h:28: T* result) {
On 2012/08/14 20:56:32, Wez wrote:
> nit: Why not return const T* and have the caller check the result for NULL?

I think that would be more confusing and harder to use.

[commit-bot: I haz the power, 2012-08-14 21:22:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10829324/1006

[commit-bot: I haz the power, 2012-08-14 23:11:46]

Try job failure for 10829324-1006 (retry) (retry) on linux_rel for step
"interactive_ui_tests".
It's a second try, previously, step "interactive_ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-08-14 23:39:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10829324/7003

[commit-bot: I haz the power, 2012-08-15 00:19:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10829324/1009