Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Issue 10829322: Merge 125486 - [chromium] renderSurface in incorrect space if owning layer has empty but non-zero b… (Closed)

Created:
8 years, 4 months ago by shawnsingh
Modified:
8 years, 4 months ago
Reviewers:
shawnsingh
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1229/
Visibility:
Public.

Description

Merge 125486 - [chromium] renderSurface in incorrect space if owning layer has empty but non-zero bounds https://bugs.webkit.org/show_bug.cgi?id=93795 Reviewed by Adrienne Walker. Source/WebCore: If a renderSurface is created by a layer that had zero area (empty) but non-zero bounds (either width or height was non-zero), then one translation transform was accidentally being skipped, causing the renderSurface drawTransform to be incorrect. The fix is simply to move that transform outside of the if-statement so it is not skipped. Unit test added: CCLayerTreeHostCommonTest.verifyTransformsForDegenerateIntermediateLayer() * platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp: (WebCore::calculateDrawTransformsInternal): Source/WebKit/chromium: * tests/CCLayerTreeHostCommonTest.cpp: TBR=shawnsingh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -3 lines) Patch
M Source/WebCore/platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/WebKit/chromium/tests/CCLayerTreeHostCommonTest.cpp View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
shawnsingh
8 years, 4 months ago (2012-08-14 17:45:49 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698