Load ICU data from file on iOS.

Load ICU data from file on iOS.

On iOS, load ICU data from a file instead of compiling it in, to keep binary
size down for the low-memory environment.

BUG=None

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151900

[blundell, 2012-08-14 15:05:35]

PTAL and advise on how to flesh out the CL description, thanks!

[stuartmorgan, 2012-08-14 15:36:54]

LGTM
+mark for OWNERS

On 2012/08/14 15:05:35, blundell wrote:
> PTAL and advise on how to flesh out the CL description, thanks!

I would say:
"On iOS, load ICU data from a file instead of compiling it in, to keep binary
size down for the low-memory environment"

This was done because ICU data was bloating the binary quite a bit, and mmaping
the data in separately is preferable to having it as part of the binary.

[stuartmorgan, 2012-08-14 15:37:53]

https://chromiumcodereview.appspot.com/10829320/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10829320/diff/1/build/common.gypi#newc...
build/common.gypi:899: 'icu_use_data_file_flag': 1,
Oh, one other thing. We should add a % to the end of this (as is done on the
other variables) so that it can be overridden externally.

[blundell, 2012-08-16 08:06:04]

PTAL, thanks!

https://chromiumcodereview.appspot.com/10829320/diff/1/build/common.gypi
File build/common.gypi (right):

https://chromiumcodereview.appspot.com/10829320/diff/1/build/common.gypi#newc...
build/common.gypi:899: 'icu_use_data_file_flag': 1,
On 2012/08/14 15:37:53, stuartmorgan wrote:
> Oh, one other thing. We should add a % to the end of this (as is done on the
> other variables) so that it can be overridden externally.

Done.

[Mark Mentovai, 2012-08-16 12:35:54]

LGTM

[commit-bot: I haz the power, 2012-08-16 14:02:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/blundell@chromium.org/10829320/5001

[commit-bot: I haz the power, 2012-08-16 16:10:39]

Change committed as 151900