Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 10829318: Make sure that shutdown blocking SequencedWorkerPool use Critical Closures. (Closed)

Created:
8 years, 4 months ago by Milan Broum
Modified:
8 years, 4 months ago
Reviewers:
stuartmorgan, brettw
CC:
chromium-reviews, erikwright+watch_chromium.org, brettw-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Make sure that shutdown blocking SequencedWorkerPool use Critical Closures. SequencedWorkerPool task that are pushed with the shutdown blocking enum must block shutdown, which means that the task execution is important enough that it has to be executed before going into background. Those tasks are transformed into CriticalTasks. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151685

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M base/threading/sequenced_worker_pool.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Milan Broum
This is part of iOS upstreaming effort. Stuart, could you do the first review pass, ...
8 years, 4 months ago (2012-08-14 14:44:29 UTC) #1
stuartmorgan
LGTM
8 years, 4 months ago (2012-08-14 15:04:42 UTC) #2
brettw
lgtm
8 years, 4 months ago (2012-08-14 20:18:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/milanb@chromium.org/10829318/1
8 years, 4 months ago (2012-08-15 09:20:38 UTC) #4
commit-bot: I haz the power
8 years, 4 months ago (2012-08-15 11:56:11 UTC) #5
Change committed as 151685

Powered by Google App Engine
This is Rietveld 408576698