Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc

Issue 10829309: Remove background_alias_do_not_use_permission (Closed) Base URL: http://git.chromium.org/git/chromium.git@trunk
Patch Set: . Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/common/extensions/permissions/api_permission.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/common/chrome_switches.h" 10 #include "chrome/common/chrome_switches.h"
11 #include "chrome/common/extensions/extension.h" 11 #include "chrome/common/extensions/extension.h"
12 #include "chrome/common/extensions/extension_error_utils.h" 12 #include "chrome/common/extensions/extension_error_utils.h"
13 #include "chrome/common/extensions/extension_manifest_constants.h" 13 #include "chrome/common/extensions/extension_manifest_constants.h"
14 #include "chrome/common/extensions/features/feature.h" 14 #include "chrome/common/extensions/features/feature.h"
15 #include "chrome/common/extensions/features/simple_feature_provider.h" 15 #include "chrome/common/extensions/features/simple_feature_provider.h"
16 #include "testing/gtest/include/gtest/gtest.h" 16 #include "testing/gtest/include/gtest/gtest.h"
17 17
18 namespace errors = extension_manifest_errors; 18 namespace errors = extension_manifest_errors;
19 19
20 namespace extensions { 20 namespace extensions {
21 21
22 TEST_F(ExtensionManifestTest, BackgroundPermission) { 22 TEST_F(ExtensionManifestTest, BackgroundPermission) {
23 LoadAndExpectError("background_permission.json", 23 LoadAndExpectError("background_permission.json",
24 errors::kBackgroundPermissionNeeded); 24 errors::kBackgroundPermissionNeeded);
25
26 scoped_refptr<Extension> extension;
27 extension = LoadAndExpectSuccess("background_permission_alias.json");
28 EXPECT_TRUE(extension->HasAPIPermission(
29 extensions::APIPermission::kBackground));
30 } 25 }
31 26
32 TEST_F(ExtensionManifestTest, BackgroundScripts) { 27 TEST_F(ExtensionManifestTest, BackgroundScripts) {
33 std::string error; 28 std::string error;
34 scoped_ptr<DictionaryValue> manifest( 29 scoped_ptr<DictionaryValue> manifest(
35 LoadManifestFile("background_scripts.json", &error)); 30 LoadManifestFile("background_scripts.json", &error));
36 ASSERT_TRUE(manifest.get()); 31 ASSERT_TRUE(manifest.get());
37 32
38 scoped_refptr<Extension> extension( 33 scoped_refptr<Extension> extension(
39 LoadAndExpectSuccess(Manifest(manifest.get(), ""))); 34 LoadAndExpectSuccess(Manifest(manifest.get(), "")));
(...skipping 64 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 EXPECT_TRUE(extension->has_lazy_background_page()); 99 EXPECT_TRUE(extension->has_lazy_background_page());
105 100
106 ListValue* permissions = new ListValue(); 101 ListValue* permissions = new ListValue();
107 permissions->Append(Value::CreateStringValue("webRequest")); 102 permissions->Append(Value::CreateStringValue("webRequest"));
108 manifest->Set(keys::kPermissions, permissions); 103 manifest->Set(keys::kPermissions, permissions);
109 LoadAndExpectError(Manifest(manifest.get(), ""), 104 LoadAndExpectError(Manifest(manifest.get(), ""),
110 errors::kWebRequestConflictsWithLazyBackground); 105 errors::kWebRequestConflictsWithLazyBackground);
111 } 106 }
112 107
113 } // namespace extensions 108 } // namespace extensions
OLDNEW
« no previous file with comments | « no previous file | chrome/common/extensions/permissions/api_permission.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698