Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 10829308: Use the last committed entry for View Source. (Closed)

Created:
8 years, 4 months ago by Charlie Reis
Modified:
8 years, 4 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Use the last committed entry for View Source. BUG=138140 TEST=Ctrl+U while a page load is in progress. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151512

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -11 lines) Patch
M chrome/browser/browser_commands_unittest.cc View 2 chunks +51 lines, -6 lines 0 comments Download
M chrome/browser/ui/browser_commands.cc View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Charlie Reis
Ben, can you take a look?
8 years, 4 months ago (2012-08-14 00:28:09 UTC) #1
Ben Goodger (Google)
lgtm
8 years, 4 months ago (2012-08-14 15:24:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/10829308/1
8 years, 4 months ago (2012-08-14 15:55:56 UTC) #3
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 18:14:51 UTC) #4
Change committed as 151512

Powered by Google App Engine
This is Rietveld 408576698