Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 10829307: Fix scons build of gpu command buffer. (Closed)

Created:
8 years, 4 months ago by binji
Modified:
8 years, 4 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M gpu/command_buffer/client/gles2_implementation.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/common/debug_marker_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/shared/ppapi_proxy/nacl.scons View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
binji
8 years, 4 months ago (2012-08-13 23:12:08 UTC) #1
greggman
scons is still used? sigh... lgtm
8 years, 4 months ago (2012-08-13 23:29:27 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/10829307/1
8 years, 4 months ago (2012-08-14 07:36:57 UTC) #3
commit-bot: I haz the power
Presubmit check for 10829307-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 4 months ago (2012-08-14 07:36:59 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/binji@chromium.org/10829307/1
8 years, 4 months ago (2012-08-14 07:45:29 UTC) #5
commit-bot: I haz the power
8 years, 4 months ago (2012-08-14 10:05:12 UTC) #6
Change committed as 151450

Powered by Google App Engine
This is Rietveld 408576698