Issue 10829305: [WebIntents, Views] Custom Close button only for new ConstrainedWindow.

Issue 10829305: [WebIntents, Views] Custom Close button only for new ConstrainedWindow. (Closed)

Created:
8 years, 4 months ago by groby-ooo-7-16

Modified:
8 years, 4 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews, gbillock+watch_chromium.org, tfarina, groby+watch_chromium.org, smckay+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[WebIntents, Views] Custom Close button only for new ConstrainedWindow. R=pkasting@chromium.org BUG=137836 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151609

Patch Set 2 : Fix review nits. #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -6 lines)			Patch
	M	chrome/browser/ui/views/web_intent_picker_views.cc	View	1	8 chunks	+22 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

LGTM https://chromiumcodereview.appspot.com/10829305/diff/1/chrome/browser/ui/views/web_intent_picker_views.cc File chrome/browser/ui/views/web_intent_picker_views.cc (right): https://chromiumcodereview.appspot.com/10829305/diff/1/chrome/browser/ui/views/web_intent_picker_views.cc#newcode815 chrome/browser/ui/views/web_intent_picker_views.cc:815: CommandLine* command_line = CommandLine::ForCurrentProcess(); Nit: Or just inline ...

8 years, 4 months ago (2012-08-14 18:20:34 UTC) #2

groby-ooo-7-16

http://codereview.chromium.org/10829305/diff/1/chrome/browser/ui/views/web_intent_picker_views.cc File chrome/browser/ui/views/web_intent_picker_views.cc (right): http://codereview.chromium.org/10829305/diff/1/chrome/browser/ui/views/web_intent_picker_views.cc#newcode815 chrome/browser/ui/views/web_intent_picker_views.cc:815: CommandLine* command_line = CommandLine::ForCurrentProcess(); On 2012/08/14 18:20:35, Peter Kasting ...

8 years, 4 months ago (2012-08-14 21:27:00 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10829305/4001

8 years, 4 months ago (2012-08-14 21:29:40 UTC) #4

Change committed as 151609

Expand Messages | Collapse Messages