Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Issue 10829293: Permit google app engine to be installed in testing_support. (Closed)

Created:
8 years, 4 months ago by gavinp
Modified:
8 years, 4 months ago
Reviewers:
cmp, M-A Ruel
CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel
Visibility:
Public.

Description

Permit google app engine to be installed in testing_support. I recently needed to run presubmit tests in depot_tools, and I was helpfully told: $ gcl presubmit mychange ... eliding stuff ... Install google_appengine sdk in /scratch/scratch/chrome/depot_tools_git/testing_support or higher up This was a lie. If you put google_appengine there, the same presubmit tools that told you to install it there will fail you for numerous style violations contained within appengine itself. This change makes us ignore those by blacklisting google_appengine inside of testing_support. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=151210

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M presubmit_support.py View 1 chunk +1 line, -0 lines 0 comments Download
M tests/presubmit_unittest.py View 2 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
gavinp
cmp, I came across this while working on my dirty-index change. What do you think?
8 years, 4 months ago (2012-08-12 17:58:32 UTC) #1
cmp
8 years, 4 months ago (2012-08-12 22:23:21 UTC) #2
lgtm, thanks!

Powered by Google App Engine
This is Rietveld 408576698