Added a histogram to track number of http/https resources.

Added a histogram to track number of http/https resources.
R=gavinp@chromium.org,darin@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=151338

[frankwang, 2012-08-10 18:29:16]

I added a histogram to track the number of http/https resources as per Gavin's
suggestion in response to the bug. This way we can track and estimate the amount
of memory for http/https only resources.

WDYT?

[darin (slow to review), 2012-08-11 06:18:35]

LGTM

https://chromiumcodereview.appspot.com/10829282/diff/1/content/browser/render...
File content/browser/renderer_host/duplicate_content_resource_handler.cc
(right):

https://chromiumcodereview.appspot.com/10829282/diff/1/content/browser/render...
content/browser/renderer_host/duplicate_content_resource_handler.cc:95: bool
is_http_or_https = request_->url().SchemeIs("http") ||
weren't you going to modify this to stop recording metrics for non-http(s) URLs?
 or otherwise put a cap on the memory leak?

https://chromiumcodereview.appspot.com/10829282/diff/1/content/browser/render...
content/browser/renderer_host/duplicate_content_resource_handler.cc:124:
UMA_HISTOGRAM_ENUMERATION("Duplicate.ResourceType.All", resource_type_,
this was part of the other CL, right?

[gavinp, 2012-08-12 16:18:46]

LGTM.

I do think it would also be good to track the size of each of the hashes
relative to the number of http/https resources we've seen. That's more subtle,
the the total resource count is a fine upper bound on that.

[gavinp, 2012-08-12 16:19:03]

And yeah, you should rebase this like Darin suggested.

On 2012/08/12 16:18:46, gavinp wrote:
> LGTM.
> 
> I do think it would also be good to track the size of each of the hashes
> relative to the number of http/https resources we've seen. That's more subtle,
> the the total resource count is a fine upper bound on that.

[frankwang, 2012-08-13 04:41:12]

A patch is in progress. I thought I would put this histogram in also to keep
track of how many http/https resources there are to understand the upper bound
of the sets. Here is a link to the other patch.

http://codereview.chromium.org/10824236/

[commit-bot: I haz the power, 2012-08-13 19:27:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/frankwang@google.com/10829282/6001

[commit-bot: I haz the power, 2012-08-13 20:43:13]

Change committed as 151338